-
Notifications
You must be signed in to change notification settings - Fork 19.8k
Comments
fix: Dump areaStyle polygon when notMerge is true#16772
Merged
plainheart merged 3 commits intoapache:master from Apr 11, 2022
Merged
fix: Dump areaStyle polygon when notMerge is true #16772plainheart merged 3 commits intoapache:master from
plainheart merged 3 commits intoapache:master from
Conversation
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.
Contributor
pissang
commented
Apr 5, 2022
LGTM
pissang
pissang
previously approved these changes
Apr 5, 2022
plainheart
plainheart
approved these changes
Apr 11, 2022
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix the problem where area shading is not removed after setting chart to be step chart without areaStyle.
Fixed issues
Details
Before: What was the problem?
When a line chart with area shade on, changes its option in notMerge mode into a step line chart and turned off the area shade, the previous area shade would not disappear. The causing code is discussed here: #16769 (comment).
After: How is it fixed in this PR?
Add an
elseto dump thepolygonifisAreaChartis false.Misc
Related test cases or examples to use the new APIs
A test case is added in test/setOption.html