-
Notifications
You must be signed in to change notification settings - Fork 652
Moving several struct variants out of Statement enum to allow for trait impls for specific sub-variants
#2057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LucaCappelletti94
wants to merge
12
commits into
apache:main
from
LucaCappelletti94:statement-structs
Open
Moving several struct variants out of Statement enum to allow for trait impls for specific sub-variants
#2057
LucaCappelletti94
wants to merge
12
commits into
apache:main
from
LucaCappelletti94:statement-structs
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@LucaCappelletti94
LucaCappelletti94
changed the title
(削除) [DRAFT] Moving all struct variants out of
(追記) Moving several struct variants out of Oct 6, 2025
Statement enum to allow for trait impls for specific sub-variants (削除ここまで)Statement enum to allow for trait impls for specific sub-variants (追記ここまで)
@LucaCappelletti94
LucaCappelletti94
marked this pull request as ready for review
October 6, 2025 13:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
As per title, in this PR I moved several of the struct variants out of the
Statementenum. This refactoring allows for implementing traits and methods which specifically expect one particular statement, and not all of them.I have focused on the variants which I am familiar with, primarily those related to PostgreSQL. There are still other struct variant which we might want to move out, such as
Drop, but that variant would need to be renamed into some other naming convention because of the collision with theDroptrait.This PR works towards solving issues such as #1204
Best,
Luca