-
Notifications
You must be signed in to change notification settings - Fork 713
IO-845 PathUtils.copyDirectory copies or follows symbolic links#827
Open
peterdemaeyer wants to merge 5 commits intoapache:master from
Open
IO-845 PathUtils.copyDirectory copies or follows symbolic links #827peterdemaeyer wants to merge 5 commits intoapache:master from
peterdemaeyer wants to merge 5 commits intoapache:master from
Conversation
...ding on the NOFOLLOW_LINKS option
garydgregory
garydgregory
requested changes
Feb 8, 2026
Member
@garydgregory
garydgregory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @peterdemaeyer !
I have a comment in the copy visitor, and a small implementation issue about comparing enums.
src/main/java/org/apache/commons/io/file/CopyDirectoryVisitor.java
Outdated
Show resolved
Hide resolved
garydgregory
garydgregory
requested changes
Feb 12, 2026
Member
@garydgregory
garydgregory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @peterdemaeyer
Thank you for your update. You'll want to run mvn by itself before you push to run all build checks; this runs the default Maven goal as defined in the POM.
src/main/java/org/apache/commons/io/file/CountingPathVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/io/file/CountingPathVisitor.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defined the behavior of
PathUtils.copyDirectoryfor symbolic links. It depends on the optionLinkOption.NOFOLLOW_LINKS. Non-symbolic (hard) links are out of scope, given that the copy behavior for them was already well-defined: they're treated as regular files.For the sake of conciseness, the following paragraphs use the term "link" for "symbolic link".
Without
NOFOLLOW_LINKSoption:FileSystemLoopException.With
NOFOLLOW_LINKSoption:All of this is also explained in the updated JavaDoc.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.