Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Amend getFullPathNoEndSeparator description for trailing slash home path behaviour#551

Open
Philzen wants to merge 1 commit intoapache:master from
Philzen:patch-1
Open

Amend getFullPathNoEndSeparator description for trailing slash home path behaviour #551
Philzen wants to merge 1 commit intoapache:master from
Philzen:patch-1

Conversation

@Philzen
Copy link

@Philzen Philzen commented Jan 4, 2024
edited
Loading

The description says it will remove the trailing slash from a home path (relative path starting with tilde).

A simple

 @Test void returnsHomeWithTrailingSlash_forHomeWithTrailingSlash() {
 assertThat(FilenameUtils.getFullPathNoEndSeparator("~/")).isEqualTo("~/");
 }

proves otherwise.

This fixes the description accordingly. NB: this behaviour has been existent since 2.4, where i discovered it.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I think the existing behavior and the changed docs are correct.

Copy link
Author

Philzen commented Apr 24, 2024

Any objections merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@elharo elharo elharo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /