-
Notifications
You must be signed in to change notification settings - Fork 713
Amend getFullPathNoEndSeparator description for trailing slash home path behaviour#551
Open
Philzen wants to merge 1 commit intoapache:master from
Open
Amend getFullPathNoEndSeparator description for trailing slash home path behaviour #551Philzen wants to merge 1 commit intoapache:master from
Philzen wants to merge 1 commit intoapache:master from
Conversation
elharo
elharo
approved these changes
Jan 5, 2024
Contributor
@elharo
elharo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I think the existing behavior and the changed docs are correct.
Author
Philzen
commented
Apr 24, 2024
Any objections merging this?
elharo
elharo
approved these changes
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The description says it will remove the trailing slash from a home path (relative path starting with tilde).
A simple
proves otherwise.
This fixes the description accordingly. NB: this behaviour has been existent since 2.4, where i discovered it.