-
Notifications
You must be signed in to change notification settings - Fork 713
Makes Tailer use ScheduledExecutorService from Java 5#2
Open
triceo wants to merge 1 commit intoapache:trunk from
Open
Makes Tailer use ScheduledExecutorService from Java 5 #2triceo wants to merge 1 commit intoapache:trunk from
triceo wants to merge 1 commit intoapache:trunk from
Conversation
This has multiple benefits: - it provides periodic runs of the read operations without needing to invoke Thread.sleep(). - it removes any looping from the run() method, making for cleaner code. - generally brings Tailer closer to what modern Java looks like. No public API changes have been made. All tests are passing without modifications.
Member
garydgregory
commented
Jul 11, 2021
@triceo
May you rebase on master?
Member
@triceo
May you plerase rebase on master? The implementation has changed to use the builder pattern with an internal Duration instead of long to track the sleep delay. It looks like the code needs to be adapted to configure the builder with an executor.
Author
triceo
commented
Sep 23, 2021
@garydgregory I may eventually get to it, but considering that the original PR is from 2014, I have moved on.
Member
garydgregory
commented
Sep 23, 2021
Either it's useful or not, regardless of your moving about 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has multiple benefits:
invoke Thread.sleep().
No public API changes have been made. All tests are passing without
modifications.