Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix NPE during reset password#12585

Open
sureshanaparti wants to merge 1 commit intoapache:4.20 from
shapeblue:reset-pswd-npe-fix
Open

Fix NPE during reset password #12585
sureshanaparti wants to merge 1 commit intoapache:4.20 from
shapeblue:reset-pswd-npe-fix

Conversation

@sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Feb 4, 2026

Description

This PR fixes the NPE during reset password, and has some code improvements. Failed to throw proper error when there is no session while resetting password.

Fixes #12582

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Contributor Author

@blueorangutan package

Copy link

codecov bot commented Feb 4, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (9ae696d) to head (1001510).

Files with missing lines Patch % Lines
...ack/api/command/SAML2LoginAPIAuthenticatorCmd.java 0.00% 6 Missing ⚠️
...loud/api/auth/DefaultLoginAPIAuthenticatorCmd.java 0.00% 3 Missing ⚠️
server/src/main/java/com/cloud/api/ApiServlet.java 0.00% 1 Missing and 1 partial ⚠️
...th2/api/command/OauthLoginAPIAuthenticatorCmd.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## 4.20 #12585 +/- ##
============================================
- Coverage 16.26% 16.26% -0.01% 
 Complexity 13428 13428 
============================================
 Files 5660 5660 
 Lines 499963 499965 +2 
 Branches 60708 60709 +1 
============================================
 Hits 81330 81330 
- Misses 409559 409562 +3 
+ Partials 9074 9073 -1
Flag Coverage Δ
uitests 4.16% <ø> (ø)
unittests 17.12% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@sudo87 sudo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Copy link
Contributor

@blueorangutan package

Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16706

Copy link
Contributor

@blueorangutan test

Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Copy link

[SF] Trillian test result (tid-15383)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 57460 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12585-t15383-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_LoginApiDomain Error 7.10 test_accounts.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sudo87 sudo87 sudo87 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.20.3

Development

Successfully merging this pull request may close these issues.

Reset password for SAML and LDAP users results in a NPE

AltStyle によって変換されたページ (->オリジナル) /