Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Create & Delete, Enable & Disable, Enter & Cancel maintenance of Prim... #12563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandeeplocharla wants to merge 2 commits into apache:main
base: main
Choose a base branch
Loading
from NetApp:netapp-ontap-primary-storage-pool

Conversation

@sandeeplocharla
Copy link

@sandeeplocharla sandeeplocharla commented Feb 1, 2026 •
edited
Loading

Create & Delete, Enable & Disable, Enter & Cancel maintenance of Primary StoragePool with ONTAP storage

Co-authored-by: Rajiv Jain rajiv1@netapp.com
Co-authored-by: Piyush Srivastava piyush5@netapp.com
Co-authored-by: Surya Gupta suryag@netapp.com

Description

NetApp ONTAP Storage Plugin

Introduction

This document describes in brief the design and implementation of the NetApp ONTAP storage plugin for Apache CloudStack. The plugin enables CloudStack to use NetApp ONTAP as a primary storage provider.

ONTAP Terminology

Term Description
SVM Storage Virtual Machine - a logical storage container that provides data access to clients
FlexVolume A logical volume that can grow or shrink within an aggregate
Aggregate A collection of physical disks that provides storage for volumes
LIF Logical Interface - a network interface for client access (Management LIF for admin, Data LIF for storage traffic)
iGroup Initiator Group - a collection of host initiator IQNs used for iSCSI access control
Export Policy A set of rules that define NFS client access to volumes

Scope

Current Implementation

The following operations are currently implemented:

Operation Description
Create Primary Storage Pool Creates a FlexVolume on ONTAP and registers it as a primary storage pool in CloudStack
Delete Primary Storage Pool Removes the storage pool from CloudStack and deletes the FlexVolume from ONTAP
Attach Cluster/Zone Creates access groups (iGroups for iSCSI, export policies for NFS) and connects hosts
Enable/Disable Storage Pool Enables or disables the storage pool for use
Enter/Cancel Maintenance Places storage pool in maintenance mode or brings it back online

Supported Configurations

Configuration Supported Values
Hypervisor KVM
ONTAP Platform Unified
Protocols NFS 3.0, iSCSI
Storage Pool Scope Cluster, Zone

Storage Pool Lifecycle

Create Storage Pool

  1. Validate input parameters (SVM, protocol, credentials)
  2. Connect to ONTAP and verify SVM state and protocol enablement
  3. Create FlexVolume on ONTAP
  4. Register storage pool in CloudStack

Attach to Cluster/Zone

  1. Identify eligible hosts in the scope
  2. Create access group (iGroup or export policy)
  3. Connect each host to the storage pool

Delete Storage Pool

  1. Delete access groups from ONTAP
  2. Delete FlexVolume from ONTAP
  3. Remove storage pool from CloudStack

Configuration Parameters

Parameters are passed via URL in semicolon-separated key=value format:

Parameter Description
username ONTAP admin username
password ONTAP admin password
managementLIF ONTAP cluster management IP
svmName Storage Virtual Machine name
protocol NFS3 or ISCSI

There are few files under feign folder which aren't currently being consumed by the workflows being proposed for review. But, they are definitely required for upcoming workflows.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

  1. Management Server Operations:

    • Added a new zone using the Management server UI.
    • Verified functionality of core and advanced zone types.

  2. Primary Storage Pool Operations:

    • Create: Verified creation of primary storage pool.
    • Delete: Verified deletion of primary storage pool.
    • Enable/Disable: Tested enabling and disabling the storage pool.
    • Maintenance Mode: Verified entering and exiting maintenance mode.
    • Cancel Maintenance: Ensured maintenance cancellation works.

Testing Environment:

  • The test setup was conducted on an Ubuntu VM with the following components installed and configured:
    • Management server
    • Cloudstack agent and KVM
    • NFS server
    • iSCSI initiator
  • Testing has been done currently with a single host.
  • Following are snapshots from the test done:
    NFS3 Primary Storage Pool - Create
Screenshot 2026年02月02日 at 4 40 22 PM Screenshot 2026年02月02日 at 4 40 40 PM

NFS3 type ONTAP Volume created

Screenshot 2026年02月02日 at 4 41 33 PM

Export Policy created on ONTAP

Screenshot 2026年02月02日 at 4 43 18 PM

Disabled Primary Storage Pool - NFS3

Screenshot 2026年02月02日 at 4 43 49 PM

Re-Enabled Primary Storage Pool - NFS3

Screenshot 2026年02月02日 at 4 43 57 PM

Enter maintenance mode - NFS3

Screenshot 2026年02月02日 at 4 44 23 PM

Cancel maintenance mode - NFS3

Screenshot 2026年02月02日 at 4 44 38 PM

Delete Primary StoragePool - NFS3

Screenshot 2026年02月02日 at 4 45 13 PM

ONTAP Volume deleted

Screenshot 2026年02月02日 at 4 45 35 PM

ONTAP ExportPolicy deleted

Screenshot 2026年02月02日 at 4 45 45 PM

iSCSI Primary Storage Pool - Delete

Screenshot 2026年02月02日 at 4 47 05 PM Screenshot 2026年02月02日 at 4 47 18 PM

iSCSI type ONTAP Volume created

Screenshot 2026年02月02日 at 4 47 42 PM

iGroup created

Screenshot 2026年02月02日 at 4 48 18 PM

Disabled Primary Storage Pool - iSCSI

Screenshot 2026年02月02日 at 4 48 47 PM

Re-Enabled Primary Storage Pool - iSCSI

Screenshot 2026年02月02日 at 4 48 58 PM

Enter maintenance mode - iSCSI

Screenshot 2026年02月02日 at 4 49 09 PM

Cancel maintenance mode - iSCSI

Screenshot 2026年02月02日 at 4 49 23 PM

Delete Primary StoragePool - iSCSI

Screenshot 2026年02月02日 at 4 49 48 PM

ONTAP iGroup deleted

Screenshot 2026年02月02日 at 4 50 52 PM

ONTAP Volume deleted

Screenshot 2026年02月02日 at 4 51 10 PM

kiranchavala reacted with thumbs up emoji luganofer and kiranchavala reacted with rocket emoji
Copy link

codecov bot commented Feb 1, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 5.59222% with 2718 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.83%. Comparing base (a5b6bc3) to head (b1792b4).

Files with missing lines Patch % Lines
...he/cloudstack/storage/service/StorageStrategy.java 0.35% 280 Missing ⚠️
...rage/lifecycle/OntapPrimaryDatastoreLifecycle.java 30.88% 209 Missing and 17 partials ⚠️
...cloudstack/storage/service/UnifiedNASStrategy.java 0.00% 200 Missing ⚠️
...org/apache/cloudstack/storage/feign/model/Lun.java 0.00% 196 Missing ⚠️
...cloudstack/storage/service/UnifiedSANStrategy.java 0.00% 186 Missing ⚠️
...pache/cloudstack/storage/feign/model/FileInfo.java 0.00% 175 Missing ⚠️
.../apache/cloudstack/storage/feign/model/Igroup.java 0.00% 155 Missing ⚠️
...che/cloudstack/storage/feign/model/ExportRule.java 0.00% 108 Missing ⚠️
...e/cloudstack/storage/feign/FeignConfiguration.java 0.00% 89 Missing ⚠️
...cloudstack/storage/listener/OntapHostListener.java 0.00% 85 Missing ⚠️
... and 32 more
Additional details and impacted files 
@@ Coverage Diff @@
## main #12563 +/- ##
============================================
- Coverage 17.89% 17.83% -0.07% 
- Complexity 16092 16119 +27 
============================================
 Files 5936 5979 +43 
 Lines 532734 535613 +2879 
 Branches 65165 65370 +205 
============================================
+ Hits 95347 95526 +179 
- Misses 426711 429392 +2681 
- Partials 10676 10695 +19
Flag Coverage Δ
uitests 3.68% <ø> (ø)
unittests 18.92% <5.59%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sandeeplocharla sandeeplocharla force-pushed the netapp-ontap-primary-storage-pool branch 2 times, most recently from c495c7c to 20d4e97 Compare February 2, 2026 12:55
@sandeeplocharla sandeeplocharla marked this pull request as ready for review February 2, 2026 14:05
@sandeeplocharla sandeeplocharla force-pushed the netapp-ontap-primary-storage-pool branch from 20d4e97 to c98cf8c Compare February 2, 2026 14:12
Copy link
Contributor

@blueorangutan package

Copy link

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16683

Copy link
Contributor

@blueorangutan test

Copy link

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Copy link
Contributor

Hey @sandeeplocharla et al,

Great work, some issues came up in the github actions. Can you first look at the license check and the pre-commit actions?
thanks for the extensive test description as well. We cannot guarantee 3rd party testing as I hope you understand. I’ll be sure to review your work and thanks again.
rajiv-jain-netapp reacted with thumbs up emoji

Copy link
Author

Hi @DaanHoogland
Thank you! I'm trying to understand the errors. For us to have more clarity, could you please help us understand in brief on what is being checked in the tests that failed?

Copy link

Hey @sandeeplocharla et al,

Great work, some issues came up in the github actions. Can you first look at the license check and the pre-commit actions? thanks for the extensive test description as well. We cannot guarantee 3rd party testing as I hope you understand. I’ll be sure to review your work and thanks again.

Thank you, @DaanHoogland. We look forward to receiving your review comments and will address them as soon as possible.

@sandeeplocharla sandeeplocharla force-pushed the netapp-ontap-primary-storage-pool branch from c98cf8c to 08b53f0 Compare February 3, 2026 10:44
Locharla, Sandeep added 2 commits February 3, 2026 17:28 
...ary StoragePool with ONTAP storage
Co-authored-by: Rajiv Jain <Rajiv.Jain@netapp.com>
Create & Delete, Enable & Disable, Enter & Cancel maintenance of Primary StoragePool with ONTAP storage
Co-authored-by: Rajiv Jain<rajiv1@netapp.com>
Edited readme file
Copy link
Author

sandeeplocharla commented Feb 3, 2026 •
edited
Loading

Hi, the project level Code coverage seems to be failing, due to mutliple files that this code is indirectly touching, doesn't have coverage. What could be done in such a case?
Also, please help us with the smoke and component tests that are failing? I don't think we have made changes that are relevant to those tests.

Copy link
Contributor

Hi, the project level Code coverage seems to be failing, due to mutliple files that this code is indirectly touching, doesn't have coverage. What could be done in such a case? Also, please help us with the smoke and component tests that are failing? I don't think we have made changes that are relevant to those tests.

@sandeeplocharla , we have ambitions on coverage that we don’t meet historically. Please trty to meet them on your part of the code, more we cannot ask. As for the failing tests, these seem te be the same that are failing on main as well. If you can give us any hints on them that will be very much appreciated ;)

Copy link
Contributor

@DaanHoogland DaanHoogland Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you do license checks on the extra dependencies added in this file?
see https://apache.org/legal/resolved.html for explanation.

Copy link
Author

@sandeeplocharla sandeeplocharla Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check the licenses and get back to you.

Copy link
Author

sandeeplocharla commented Feb 3, 2026 •
edited
Loading

Hi, the project level Code coverage seems to be failing, due to mutliple files that this code is indirectly touching, doesn't have coverage. What could be done in such a case? Also, please help us with the smoke and component tests that are failing? I don't think we have made changes that are relevant to those tests.

@sandeeplocharla , we have ambitions on coverage that we don’t meet historically. Please trty to meet them on your part of the code, more we cannot ask. As for the failing tests, these seem te be the same that are failing on main as well. If you can give us any hints on them that will be very much appreciated ;)

This PR does not have the benchmark coverage that we usually aim for within our team. But, we plan on having maximum code coverage possible with the upcoming PRs. As for this PR, there are around 5400 indirect files because of which the coverage dropped. I'm not sure, how we would able to handle them all.
Will try to see if there's anything that we could do in RCA for the failing tests, but, in the meanwhile, please let us know how we could proceed from here?

Copy link

[SF] Trillian test result (tid-15359)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54505 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12563-t15359-kvm-ol8.zip
Smoke tests completed. 146 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_provision_certificate Error 121.48 test_certauthority_root.py
ContextSuite context=TestListIdsParams>:teardown Error 1.11 test_list_ids_parameter.py
test_01_snapshot_root_disk Error 5.22 test_snapshots.py
test_02_list_snapshots_with_removed_data_store Error 45.47 test_snapshots.py
test_02_list_snapshots_with_removed_data_store Error 45.48 test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown Error 28.38 test_snapshots.py
test_01_snapshot_usage Error 25.62 test_usage.py
test_01_vpn_usage Error 1.07 test_usage.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

Assignees

No one assigned

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /