Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix template details deletion while updating template from UI #12559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sureshanaparti wants to merge 1 commit into apache:4.20
base: 4.20
Choose a base branch
Loading
from shapeblue:fix-details-in-update-template

Conversation

@sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Jan 30, 2026 •
edited
Loading

Description

This PR fixes the template details deletion while updating template from UI.

Fixes #12456

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Updated rootdiskcontoller for the template (having some existing details) from UI.

How did you try to break this feature and the system with this change?

Copy link
Contributor Author

@blueorangutan ui

Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Jan 30, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (25eacaa) to head (99c06e0).
⚠️ Report is 3 commits behind head on 4.20.

Files with missing lines Patch % Lines
...che/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 0.00% 2 Missing ⚠️
.../java/com/cloud/storage/dao/VMTemplateDaoImpl.java 0.00% 2 Missing ⚠️
...n/java/com/cloud/template/TemplateManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## 4.20 #12559 +/- ##
============================================
- Coverage 16.26% 16.26% -0.01% 
 Complexity 13428 13428 
============================================
 Files 5660 5660 
 Lines 499914 499955 +41 
 Branches 60696 60706 +10 
============================================
+ Hits 81318 81319 +1 
- Misses 409523 409563 +40 
 Partials 9073 9073
Flag Coverage Δ
uitests 4.16% <ø> (-0.01%) ⬇️
unittests 17.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12559 (QA-JID-866)

Copy link
Contributor Author

@blueorangutan package

Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16655

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Copy link
Contributor

@blueorangutan test

Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Copy link

[SF] Trillian test result (tid-15350)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51329 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12559-t15350-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
sureshanaparti reacted with hooray emoji

Copy link
Contributor

@sureshanaparti As discussed the issue still exists, tested with the pr packages
sureshanaparti reacted with thumbs up emoji

@sureshanaparti sureshanaparti marked this pull request as draft February 2, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@kiranchavala kiranchavala Awaiting requested review from kiranchavala

@vishesh92 vishesh92 Awaiting requested review from vishesh92

Projects

None yet

Milestone

4.20.3

Development

Successfully merging this pull request may close these issues.

Existing Template Settings are deleted when an Update Template api is executed

AltStyle によって変換されたページ (->オリジナル) /