Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

set width of dropdown select items for Network Offering #11899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaanHoogland wants to merge 1 commit into apache:main
base: main
Choose a base branch
Loading
from shapeblue:ghi11861-dropdownWidthForNetOffer

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Oct 23, 2025

set width of dropdown select items for Network Offering during add tier dialog

Description

This PR is kind of experimental but, ...

Fixes: #11861

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Oct 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.76%. Comparing base (e25cf43) to head (2ab28ff).
⚠️ Report is 70 commits behind head on main.

Additional details and impacted files 
@@ Coverage Diff @@
## main #11899 +/- ##
============================================
+ Coverage 17.59% 17.76% +0.16% 
- Complexity 15599 15863 +264 
============================================
 Files 5910 5923 +13 
 Lines 529707 530556 +849 
 Branches 64719 64830 +111 
============================================
+ Hits 93213 94263 +1050 
+ Misses 426002 425747 -255 
- Partials 10492 10546 +54
Flag Coverage Δ
uitests 3.57% <ø> (-0.01%) ⬇️
unittests 18.85% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@blueorangutan ui

Copy link
Contributor

@DaanHoogland

A little bit better.

Can the entire description be displayed

"Offering for Isolated Vpc networks with Source Nat service enabled and LB service Disabled"

Screenshot 2025年10月31日 at 10 10 53 AM

Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can scroll the description

Screenshot 2025年10月31日 at 2 00 01 PM

@DaanHoogland DaanHoogland force-pushed the ghi11861-dropdownWidthForNetOffer branch from 8595ed7 to b60d8fb Compare October 31, 2025 08:32
@DaanHoogland DaanHoogland marked this pull request as ready for review October 31, 2025 08:33
@DaanHoogland DaanHoogland added this to the 4.22.1 milestone Nov 4, 2025
Copy link
Contributor

@DaanHoogland I feel a bit more elegant way could be showing a tooltip when the item is hovered,

image 
diff --git a/ui/src/views/network/VpcTiersTab.vue b/ui/src/views/network/VpcTiersTab.vue
index 4f6aaef444..7fe706daba 100644
--- a/ui/src/views/network/VpcTiersTab.vue
+++ b/ui/src/views/network/VpcTiersTab.vue
@@ -194,7 +194,11 @@
 :filterOption="(input, option) => {
 return option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0
 }" >
- <a-select-option v-for="item in networkOfferings" :key="item.id" :value="item.id" :label="item.displaytext || item.name || item.description">
+ <a-select-option
+ v-for="item in networkOfferings"
+ :key="item.id"
+ :value="item.id"
+ :title="item.displaytext || item.name || item.description">
 {{ item.displaytext || item.name || item.description }}
 </a-select-option>
 </a-select>
DaanHoogland reacted with heart emoji

@DaanHoogland DaanHoogland force-pushed the ghi11861-dropdownWidthForNetOffer branch from 48b4ab4 to 5aca736 Compare December 8, 2025 15:57
@apache apache deleted a comment from blueorangutan Dec 8, 2025
@apache apache deleted a comment from blueorangutan Dec 8, 2025
@apache apache deleted a comment from blueorangutan Dec 8, 2025
@apache apache deleted a comment from blueorangutan Dec 8, 2025
@apache apache deleted a comment from blueorangutan Dec 8, 2025
@apache apache deleted a comment from blueorangutan Dec 8, 2025
@apache apache deleted a comment from blueorangutan Dec 9, 2025
@apache apache deleted a comment from blueorangutan Dec 9, 2025
@apache apache deleted a comment from blueorangutan Dec 9, 2025
@apache apache deleted a comment from blueorangutan Dec 9, 2025
Copy link
Contributor Author

@blueorangutan ui

Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11899 (QA-JID-826)

Copy link
Contributor Author

@kiranchavala @shwstppr, can you have another look?

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested on QA server

Image

Though I see same problem in Update form form a network tier as well. At some point may be we should move all selects to InfiniteScrollSelect... with this tooltip behaviour

DaanHoogland reacted with thumbs up emoji
@DaanHoogland DaanHoogland force-pushed the ghi11861-dropdownWidthForNetOffer branch from 9cd5d06 to 03b5224 Compare December 23, 2025 19:57
Copy link
Contributor Author

@blueorangutan ui

Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11899 (QA-JID-834)

Copy link
Contributor Author

ping @kiranchavala

Copy link

@DaanHoogland Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?
DaanHoogland reacted with thumbs up emoji

@DaanHoogland DaanHoogland force-pushed the ghi11861-dropdownWidthForNetOffer branch from 03b5224 to 2ab28ff Compare January 12, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@kiranchavala kiranchavala Awaiting requested review from kiranchavala

Assignees

No one assigned

Projects

Status: In Progress

Milestone

4.22.1

Development

Successfully merging this pull request may close these issues.

UI : Complete network offering name is not displayed when creating a network tier in a vpc

AltStyle によって変換されたページ (->オリジナル) /