-
Notifications
You must be signed in to change notification settings - Fork 299
Support Clang variants (including AppleClang) for cmake builds#586
Open
toptobes wants to merge 1 commit into
Open
Support Clang variants (including AppleClang) for cmake builds #586toptobes wants to merge 1 commit into
toptobes wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
With CMake 3.0,
AppleClangis now a separate compiler target which needs to be explicitly accounted for to allow the driver to easily be built on Mac, and as per further discussion with Brett, we've decided to allow all clang variants here using"${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang$", and if any of them end up having any unfortunate issues with flag compatibility, we can deal with them on a case-by-case basisBuild succeeds on