-
Notifications
You must be signed in to change notification settings - Fork 299
CPP-1006 Initial version of a Windows config for Github Actions#567
CPP-1006 Initial version of a Windows config for Github Actions #567absurdfarce wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appears to be necessary to setup MSVC env properly. More at the Githubs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static zlib required for build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zlibstatic is apparently the expected name but the static build uses the default filename... so we manually fix it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This header file isn't included in the krb5 vcpkg build. At least for modern versions of the gssapi lib this header isn't especially interesting so it seemed easy enough to remove.
absurdfarce
commented
Nov 6, 2024
Worth noting that this isn't 💯 yet. Outstanding issues at this writing:
- Only running against Windows 2019, need to setup a matrix
- We're seeing several test failures due to missing host configs
- Newer versions of MSVC include checks for memory leaks and apparently some of our unit tests are triggering those
I'm not necessarily looking for bullet-proof answers to each of these points before we merge this; I expect this process will iteratively get better over time.
absurdfarce
commented
Sep 25, 2025
Replaced by #576
No description provided.