-
Notifications
You must be signed in to change notification settings - Fork 299
Conversation
mpenick
commented
May 6, 2020
Thanks for the operators. I'd prefer these live in a C++ specific header and could you add some tests?
f8e12d5 to
1f7c519
Compare
lgeorget
commented
Jul 10, 2020
Hello (a few months later...)!
So, I've put the operators in a separate header and added tests. However, I've maintained the inclusion of the operators in the main include file (cassandra.h) in order to avoid having to include another header for the operators only. I'm not sure this if this is ok or not. Should we just leave C++-only code in the other header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this block. This is broken without adding it to build and packaging.
These operators (for C++) make CassUuid instances usable as keys in std::set, std::map, etc. containers.
lgeorget
commented
Jul 15, 2020
Hmm, yes... I've renamed the include file, added it to CMakeLists.txt and to the Debian packaging files list. I've tested the packaging under Debian but I'm not able to testHomebrew right now.
1f7c519 to
1f54b39
Compare
Hello Cassandra developers
I've needed operator<() and operator==() implementations for CassUuid variables for a project in which I use CassUuid in std::set or as keys in std::map objects.
Of course, they're pretty trivial to implement but maybe it would be nice to have them in cassandra.h (even if they are for C++ only)?