-
Notifications
You must be signed in to change notification settings - Fork 4.3k
GH-51273: [Ruby] Add FixedSizeListArray values constructor - #51274
Open
emecii wants to merge 1 commit into
Open
GH-51273: [Ruby] Add FixedSizeListArray values constructor #51274emecii wants to merge 1 commit into
emecii wants to merge 1 commit into
Conversation
@github-actions
github-actions
Bot
added
Component: Ruby
awaiting review
Awaiting review
labels
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Rationale for this change
GH-50382 requests explicit value constructors for all existing
ArrowFormat::Typesubclasses before the broader builder API is exposed. Fixed-size lists still require callers to manually construct the parent validity buffer and flattened child array.This is the focused fixed-size-list prerequisite requested in the GH-50382 maintainer discussion. It is distinct from variable-size
ListArraysupport in GH-51262.What changes are included in this PR?
ArrowFormat::FixedSizeListArray.new(type, values)while preserving the existing low-level four-argument constructor.type.sizechild slots for null parent lists.Are these changes tested?
Yes.
I also wrote an Arrow IPC file containing
[[1, 2], nil, [3, nil]]with the new constructor and loaded it with the native Arrow reader; the values round-tripped unchanged.The tests use the current
red-arrow-formatsources with the locally installed Arrow 25.0.1 native extension. Upstream CI remains authoritative for the matching main-branch native runtime.Are there any user-facing changes?
Yes.
ArrowFormat::FixedSizeListArraygains a two-argument values constructor. The existing low-level constructor remains supported.AI assistance disclosure
OpenAI Codex assisted with issue research, implementation, test generation, validation commands, and drafting this pull request. The submitted behavior is supported by the focused regression, full package suite, and IPC round-trip results above.
ArrowFormat::FixedSizeListArray.new(type, values)#51273