Skip to content

Navigation Menu

Sign in
Sign up

GH-50659: [C++][Dev] Implement ListView support in gdb_arrow.py - #50661

Open
KHARSHAVARDHAN-eng wants to merge 1 commit into
apache:main from
KHARSHAVARDHAN-eng:gh-50659-listview-gdb
Open

GH-50659: [C++][Dev] Implement ListView support in gdb_arrow.py #50661
KHARSHAVARDHAN-eng wants to merge 1 commit into
apache:main from
KHARSHAVARDHAN-eng:gh-50659-listview-gdb

Conversation

@KHARSHAVARDHAN-eng

@KHARSHAVARDHAN-eng KHARSHAVARDHAN-eng commented Jul 27, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Why are these changes needed?

gdb_arrow.py currently does not support pretty-printing for ListView and LargeListView data types.

This PR adds debugger support for these types while reusing the existing pretty-printer infrastructure.

What changes are included?

  • Add LIST_VIEW and LARGE_LIST_VIEW type registration.
  • Reuse the existing pretty-printer implementation where appropriate.
  • Add debugger fixtures.
  • Add GDB test coverage for the new types.

Are these changes tested?

Yes.

  • Added GDB tests.
  • Ran the relevant debugger tests locally.
  • Verified Python syntax.
  • Verified pre-commit hooks.
  • Verified formatting.

Are there any user-facing changes?

No.

This change only improves the developer debugging experience.

Copy link
Copy Markdown

⚠️ GitHub issue #50659 has been automatically assigned in GitHub to PR creator.

Copy link
Copy Markdown
Collaborator

Could you update the PR description to follow the standard PR template? It looks like the placeholder text is still present. Replacing it with the rationale, changes, testing, and removing the unused sections would make the PR easier to review.

Thanks for contributing!

Copy link
Copy Markdown
Author

Thanks for pointing that out! I've updated the PR description to follow the standard template and removed the placeholder text.
Reranko05 reacted with thumbs up emoji

Copy link
Copy Markdown

⚠️ GitHub issue #50659 has been automatically assigned in GitHub to PR creator.

Comment thread cpp/gdb_arrow.py

@Reranko05 Reranko05 Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overlaps with GH-50662 since both PRs modify the same Type enum definition in gdb_arrow.py. They will likely conflict when merged. Could you rebase one after the other lands (or combine them if appropriate)?

Copy link
Copy Markdown
Author

Thanks for pointing that out!

I'll keep these as separate PRs since they correspond to separate issues. Once one of them lands, I'll rebase the other on top of the updated main to resolve the overlap.
Reranko05 reacted with thumbs up emoji

Copy link
Copy Markdown
Author

Hi reviewers,

I've rebased this PR onto the latest main (which now includes GH-50680).

The redundant manual enum registration has been removed, and this PR now contains only the ListView / LargeListView pretty-printer implementation along with the corresponding GDB tests.

Please let me know if there are any further changes you'd like me to make. Thanks for your review!

fenfeng9 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

LGTM from my side. cc @pitrou

Copy link
Copy Markdown
Author

i am in process of looking back to the pr i already made, before making new ones!!!!

The ARM64 macOS failure appears unrelated to this PR. The build fails in the bundled google-cloud-cpp dependency due to a deprecated absl::visit being treated as an error (-Werror). This appears to be tracked separately in GH-50868.

uros-b
uros-b previously approved these changes Aug 20, 2026

uros-b commented Aug 20, 2026

Copy link
Copy Markdown
Member

Thank you @KHARSHAVARDHAN-eng!

Copy link
Copy Markdown
Author

Hi @pitrou @AlenkaF @raulcd @rok, just following up on this PR. The requested changes have been addressed and the PR is ready for review. Thanks!

1 similar comment

Copy link
Copy Markdown
Author

Hi @pitrou @AlenkaF @raulcd @rok, just following up on this PR. The requested changes have been addressed and the PR is ready for review. Thanks!

KHARSHAVARDHAN-eng commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Hi @pitrou @AlenkaF @raulcd @rok, just following up on this PR. The requested changes have been addressed and the PR is ready for review. Please take a look at it when your free!!

Thanks!

1 similar comment

Copy link
Copy Markdown
Author

Hi @pitrou @AlenkaF @raulcd @rok, just following up on this PR. The requested changes have been addressed and the PR is ready for review. Please take a look at it when your free!!

Thanks!

thisisnic dismissed uros-b’s stale review September 7, 2026 14:12

Requires committer review

@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou Awaiting requested review from pitrou pitrou is a code owner
@AlenkaF AlenkaF Awaiting requested review from AlenkaF AlenkaF is a code owner
@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner
@rok rok Awaiting requested review from rok rok is a code owner
2 more reviewers
@Reranko05 Reranko05 Reranko05 left review comments
@uros-b uros-b uros-b left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /