Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[AMORO-3914] Support get statistics from Paimon #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xuzifu666 wants to merge 5 commits into apache:master
base: master
Choose a base branch
Loading
from xuzifu666:statics_add

Conversation

@xuzifu666
Copy link
Member

@xuzifu666 xuzifu666 commented Nov 7, 2025

Why are the changes needed?

Close #3914.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@xuzifu666 xuzifu666 changed the title (削除) [Improvement]: Support get statistics from Paimon (削除ここまで) (追記) [AMORO-3914] Support get statistics from Paimon (追記ここまで) Nov 7, 2025
Copy link
Contributor

czy006 commented Dec 11, 2025

@xuzifu666 Will this api be compatible with the viewing of iceberg static information in the future?

Copy link
Contributor

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions

@Override
public StatisticsBaseInfo getTableStatistics(AmoroTable<?> amoroTable) {
// hudi doesn't support statistics
return new StatisticsBaseInfo();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default implementation we can make in the interface is:throw new UnsupportedOperationException

statistics.schemaId(),
statistics.mergedRecordCount().getAsLong(),
statistics.mergedRecordSize().getAsLong(),
Collections.emptyMap());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's about colStats info ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czy006 czy006 czy006 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Improvement]: Support get statistics from Paimon

AltStyle によって変換されたページ (->オリジナル) /