-
Notifications
You must be signed in to change notification settings - Fork 80
New features, bugfixes, better testing #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ded support for different angle units, hwb(), and decimal values
...otal" (which you'll notice is quite a bit higher than -o would have shown)
...eyword including dashes (Also: it doesn�t work; try a similar exclusion to avoid `width: calc(100px * tan(45deg))` and you'll find you can�t.)
...color attribute support
also made the default run (all test files) work from any directory
Support non-percent saturation/luminance & whiteness/blackness in SASS and SCSS but prevent them in standard CSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
-o
doesn't work)color: rgb(0, 17, 136 / 100%)
)color: hsl(167grad, 30%, 60%)
)color: rgb(0 16.99 136)
)<body text="blue">
and<font color="#abcdef">
)Benchmark testing showed no appreciable increase in cost to run, but I don't like how inconsistent its stats are.
To implement
hwb()
, I abstractedhsl2color()
tohsl2rgb()
in order to retain the RGB channels. While at it, I also converted the other similar functions so there's now only one place where RGB is converted to hexadecimal representation.