-
Notifications
You must be signed in to change notification settings - Fork 48
Comments
Domino style menu to show approximate ping times at a glance#6
Open
nicpottier wants to merge 4 commits intoantirez:master from
Open
Domino style menu to show approximate ping times at a glance #6nicpottier wants to merge 4 commits intoantirez:master from
nicpottier wants to merge 4 commits intoantirez:master from
Conversation
Owner
antirez
commented
Nov 12, 2016
Thanks @nicpottier! Yes I still use iconping regularly, the change looks very useful, I'll install XCode in order to try it and merge. Thanks.
Author
nicpottier
commented
Nov 14, 2016
Great, ya, feel free to refactor it, was mostly just a toy thing for me, so lots of copy/paste in there instead of figuring out the right way to do it in ObjC etc..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Antirez, big fan of yours, we use Redis a ton in RapidPro and it is a lifesaver, always been impressed by your pragmatism and creation of useful tools.
Anyways, I spend a lot of time abroad on flakey connections and like having something like iconping running all the time. Not sure if you still use it, but the icon kind of drove me nuts so I made some small tweaks to change the icon to be a domino, between 1-9 representing the ping time. That tells me at a quick glance whether my ping times are ~<100ms or ~300ms or ~700ms or something greater (in which case it shows an exclamation mark)
Anyways, all pretty self explanatory from the code changes and icon files below. I made them at both resolutions so it looks good on retina displays.
Made these changes and been using it for six months or so and kinda forgot about it, but thought you might like it if you still use this in your daily life.
Either way, cheers!