-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ds4_server: Add /health endpoint that returns HTTP 200 once model is fully loaded#374
Open
mcmalayalam wants to merge 1 commit into
Open
ds4_server: Add /health endpoint that returns HTTP 200 once model is fully loaded #374mcmalayalam wants to merge 1 commit into
mcmalayalam wants to merge 1 commit into
Conversation
shagghiesuperstar
pushed a commit
to shagghiesuperstar/ds4-dashboard
that referenced
this pull request
Jun 12, 2026
The dashboard previously probed non-existent /telem and /metrics endpoints. Now uses /health (merged via antirez/ds4#374, mcmalayalam) which is the canonical liveness/readiness endpoint. Engine client simplified — single source, no metrics fallback, no _derive_metrics_url. Related: shagghiesuperstar/ds4#326 (full /info + /config PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a simple
/healthHTTP endpoint to ds4_server.c, which returns200 OKonce a model is fully loaded, and503 Service Unavailableotherwise.References to existing issues and pull requests
This fixes issue #334, so that tools such as llama-swap can start
ds4-serverand detect when it is ready to receive requests.I note that there is open PR #326 which implements a more full-featured
/healthendpoint along with other endpoints. If that PR is favoured and merged I'm more than happy to close this one.Test evidence
Manually tested with llama-swap and ds4-server on Strix Halo.
ds4-serverlogs:llama-swaplogs: