Skip to content

This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Typos #5394

Open

imechemi wants to merge 3 commits into angular:master

from imechemi:patch-1

Open

Typos #5394

Changes from all commits

Commits

Show all changes

Select commit Hold shift + click to select a range

Update webdriver.js

imechemi Feb 6, 2020

Update async-await.md

imechemi Feb 6, 2020

Update async-await.md

imechemi Feb 7, 2020

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

4 changes: 2 additions & 2 deletions docs/async-await.md

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -44,14 +44,14 @@ describe('angularjs homepage', function() {

		As you can see, the syntax is almost the same with TypeScript async/await.

	1. We need wrap our asynchronous function with "async".
	1. We need to wrap our asynchronous function with "async".
		1. We can add "await" keyword to each operation that we want our program to
		wait for.

		Note: Never forget to add "await" keyword in an async function, it
		may bring some unexpected problem (e.g. your test might fail silently and
		always be reported as passed).
	1. Don’t forget to turn off control_flow, you cannot use a mix of `async`/`await` and the control flow:
	1. Don’t forget to turn off control flow, you cannot use a mix of `async`/`await` and the control flow:
		`async`/`await` causes the control flow to become unreliable (see
		[github issue]( https://github.com/SeleniumHQ/selenium/issues/3037)). So if you
		`async`/`await` anywhere in a spec, you should use the
Expand Down

2 changes: 1 addition & 1 deletion lib/selenium-webdriver/webdriver.js

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -258,7 +258,7 @@ webdriver.WebDriver.prototype.call = function(fn, opt_scope, var_args) {};
		* will cause Protractor to wait before sending future commands to the selenium
		* server), and only when the webdriver control flow is enabled.
		*
	* This function returnes a promise, which can be used if you need to block
	* This function returns a promise, which can be used if you need to block
		* javascript execution and not just the control flow.
		*
		* See also {@link ExpectedConditions}
Expand Down