Skip to content

Navigation Menu

Sign in
Sign up
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix: add generic type for ModuleWithProviders - #245

Open
CaerusKaru wants to merge 1 commit into
angular:master from
CaerusKaru:adam/mwp
Open

fix: add generic type for ModuleWithProviders #245
CaerusKaru wants to merge 1 commit into
angular:master from
CaerusKaru:adam/mwp

Conversation

@CaerusKaru

@CaerusKaru CaerusKaru commented Oct 17, 2019

Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member Author

Ref: angular/angular#33217

Copy link
Copy Markdown
Member Author

cc @IgorMinar @brandonroberts @kara

Copy link
Copy Markdown

Hey guys, would it be possible to take a look at this PR? When trying to update to Angular 9, I get this error and was going to write a ticket but I guess @CaerusKaru has fixed it here (appreciated!)
baburner reacted with thumbs up emoji

Copy link
Copy Markdown
Contributor

I don't have access to merge anything here, so it will have to be merged before I can publish a release

Copy link
Copy Markdown

cc @IgorMinar @brandonroberts @kara
Any plans to release this fix? Thanks. Aparna

Copy link
Copy Markdown

cc @IgorMinar @brandonroberts @kara
Any plans to release this fix? Thanks. Aparna

Might be good to know! Otherwise we have to find a replacement for the in-memory-web-api when migrating to Angular 9

(And we can't wait forever ;) )

Copy link
Copy Markdown
Contributor

Thanks for your patience.

I'll merge it locally, publish a new version, and open a PR for those changes. I'll update here when it's done
baburner, aparna999, and clark-stevenson reacted with thumbs up emoji

Copy link
Copy Markdown
Contributor

0.10.0 has been published to npm with #251 containing those changes
aparna999 and baburner reacted with thumbs up emoji clark-stevenson reacted with heart emoji

Copy link
Copy Markdown

0.10.0 has been published to npm with #251 containing those changes

Thank you. Works now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /