-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/sort): error if signal is bound to disabled input #31776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sort header clears a signal when the focused state of its descendants changes. This was causing a signal write error if a signal is bound to its `disabled` input, because changing the disabled state also ends up blurring the focused descendant. Fixes angular#31723.
@crisbeto
crisbeto
added
the
target: patch
This PR is targeted for the next patch release
label
Aug 24, 2025
@crisbeto
crisbeto
requested review from
andrewseguin and
wagnermaciel
and removed request for
a team
August 24, 2025 08:20
adolgachev
adolgachev
approved these changes
Aug 25, 2025
@crisbeto
crisbeto
added
the
action: merge
The PR is ready for merge by the caretaker
label
Aug 25, 2025
The changes were merged into the following branches: main, 20.2.x
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
@angular-automatic-lock-bot
angular-automatic-lock-bot
bot
locked and limited conversation to collaborators
Sep 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sort header clears a signal when the focused state of its descendants changes. This was causing a signal write error if a signal is bound to its
disabledinput, because changing the disabled state also ends up blurring the focused descendant.Fixes #31723.