-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(cdk/menu): picking up items from child menu #31684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the CDK menu was picking up items from nested menu instances which in turn were throwing off the keyboard navigation. Fixes angular#31678.
@crisbeto
crisbeto
requested review from
adolgachev
and removed request for
a team
August 12, 2025 09:33
@crisbeto
crisbeto
added
the
target: patch
This PR is targeted for the next patch release
label
Aug 12, 2025
wagnermaciel
wagnermaciel
approved these changes
Aug 12, 2025
@crisbeto
crisbeto
added
the
action: merge
The PR is ready for merge by the caretaker
label
Aug 12, 2025
The changes were merged into the following branches: main, 20.1.x
crisbeto
added a commit
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the CDK menu was picking up items from nested menu instances which in turn were throwing off the keyboard navigation.
Fixes #31678.