fix(cdk/scrolling): use capturing for scroll event #30824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

crisbeto wants to merge 1 commit into angular:main

from crisbeto:cdk-scroll-capturing

Open

fix(cdk/scrolling): use capturing for scroll event #30824

crisbeto wants to merge 1 commit into angular:main from crisbeto:cdk-scroll-capturing

Conversation

crisbeto

Copy link

Member

@crisbeto crisbeto commented Apr 8, 2025

Historically we have asked users to indicate their scrollable regions with CdkScrollable so that we don't over-subscribe to scroll events, however the downside is that it's very easy to forget to add it or to misspell the name. This becomes an even larger issue with standalone, because users also have to import CdkScrollable. As a result, we've had lots of issue reports related to scrolling in the past, the most recent being #30586 (comment).

These changes switch to using a root capturing event on the body instead which will notify us of all scroll events automatically and will remove the need for users to set cdkScrollable in most cases.

@crisbeto


 fix(cdk/scrolling): use capturing for scroll event

442f739

Historically we have asked users to indicate their scrollable regions with `CdkScrollable` so that we don't over-subscribe to scroll events, however the downside is that it's very easy to forget to add it or to misspell the name. This becomes an even larger issue with standalone, because users also have to import `CdkScrollable`. As a result, we've had lots of issue reports related to scrolling in the past, the most recent being angular#30586 (comment).
These changes switch to using a root capturing event on the `body` instead which will notify us of all scroll events automatically and will remove the need for users to set `cdkScrollable` in most cases.