-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/autocomplete): don't reset active option if list of options changes #16616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
crisbeto
wants to merge
1
commit into
angular:main
from
crisbeto:16608/autocomplete-option-change-reset
Open
fix(material/autocomplete): don't reset active option if list of options changes #16616
crisbeto
wants to merge
1
commit into
angular:main
from
crisbeto:16608/autocomplete-option-change-reset
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@crisbeto
crisbeto
added
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
labels
Jul 26, 2019
@googlebot
googlebot
added
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Jul 26, 2019
jelbourn
jelbourn
previously approved these changes
Jul 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jelbourn
jelbourn
added
pr: lgtm
action: merge
The PR is ready for merge by the caretaker
labels
Jul 26, 2019
@crisbeto
crisbeto
force-pushed
the
16608/autocomplete-option-change-reset
branch
from
August 21, 2019 19:08
2fd76ac to
f9294f0
Compare
@andrewseguin
andrewseguin
added
presubmit failures
This PR has failures in Google's internal presubmit process and cannot be immediately merged
and removed
action: merge
The PR is ready for merge by the caretaker
labels
Aug 21, 2019
Presubmit failures - Looks like some tests rely on the fact that they can insert options after the panel is opened and expect the first item to be active. This is not the case now that option changes do not activate the first item
@andrewseguin
andrewseguin
removed
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Dec 28, 2021
...ons changes Currently we reset the active option whenever the list of items changes, however this means that the user's selection could be lost while they're interacting, if some items get added to the end of the list out of view (e.g. if the options are fetched via polling). These changes address the issue by only resetting the active option when the panel is opened. Fixes angular#16608.
@crisbeto
crisbeto
force-pushed
the
16608/autocomplete-option-change-reset
branch
from
March 13, 2022 11:22
f9294f0 to
01209a2
Compare
@crisbeto
crisbeto
changed the title
(削除) fix(autocomplete): don't reset active option if list of options changes (削除ここまで)
(追記) fix(material/autocomplete): don't reset active option if list of options changes (追記ここまで)
Mar 13, 2022
@crisbeto
crisbeto
added
action: merge
The PR is ready for merge by the caretaker
and removed
needs rebase
presubmit failures
This PR has failures in Google's internal presubmit process and cannot be immediately merged
labels
Mar 13, 2022
I've rebased this and come up with a different approach to try and minimize presubmit issues. Will run another presubmit to verify.
The alternate approach broke a bunch of clients, because the first option no longer gets activated after the user filters the list.
@andrewseguin
andrewseguin
added
needs rebase
and removed
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
labels
Mar 24, 2022
@josephperrott
josephperrott
added
action: cleanup
The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews
and removed
needs rebase
labels
Nov 16, 2022
@josephperrott
josephperrott
requested review from
amysorto and
mmalerba
and removed request for
a team
December 18, 2024 17:40
@mmalerba
mmalerba
added
presubmit failures
This PR has failures in Google's internal presubmit process and cannot be immediately merged
and removed
action: merge
The PR is ready for merge by the caretaker
labels
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we reset the active option whenever the list of items changes, however this means that the user's selection could be lost while they're interacting, if some items get added to the end of the list out of view (e.g. if the options are fetched via polling).
These changes address the issue by only resetting the active option when the panel is opened.
Fixes #16608.