fix(autocomplete): form control being marked as touched too early when clicking on an option #11908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

crisbeto wants to merge 1 commit into angular:main

from crisbeto:11903/autocomplete-mark-as-touched

Open

fix(autocomplete): form control being marked as touched too early when clicking on an option #11908

crisbeto wants to merge 1 commit into angular:main from crisbeto:11903/autocomplete-mark-as-touched

+60 −8

Conversation

crisbeto

Copy link

Member

@crisbeto crisbeto commented Jun 24, 2018

Currently we mark the autocomplete form control as touched on every blur event. This can be an issue for the case where a control is being validated on blur, because the input becomes blurred as soon as the user has their pointer down on something else (e.g. one of the options). This will cause validation to run before the value has been assigned. With these changes we switch to marking the control as touched once the panel has been closed.

Fixes #11903.

@crisbeto crisbeto assigned jelbourn

Jun 24, 2018

@googlebot googlebot added the cla: yes label

Jun 24, 2018

josephperrott

josephperrott previously approved these changes

Jun 26, 2018

View reviewed changes

Copy link

Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge target: patch labels

Jun 26, 2018

@crisbeto crisbeto force-pushed the 11903/autocomplete-mark-as-touched branch from 0c7b057 to 707905c Compare

January 4, 2019 16:04

@mmalerba mmalerba added aaa and removed aaa labels

Apr 25, 2019

@andrewseguin andrewseguin added the P3 label

May 30, 2019

@crisbeto crisbeto force-pushed the 11903/autocomplete-mark-as-touched branch from 707905c to 078ece6 Compare

July 19, 2019 19:45

@crisbeto crisbeto force-pushed the 11903/autocomplete-mark-as-touched branch from 078ece6 to 98c9a4a Compare

August 25, 2019 14:05

@crisbeto crisbeto force-pushed the 11903/autocomplete-mark-as-touched branch from 98c9a4a to d0b8dd5 Compare

January 4, 2020 15:28

@mmalerba mmalerba removed the lgtm label

Jul 31, 2020

@andrewseguin andrewseguin added the needs rebase label

Aug 14, 2020

@crisbeto crisbeto removed the needs rebase label

Aug 29, 2020

@crisbeto crisbeto force-pushed the 11903/autocomplete-mark-as-touched branch from d0b8dd5 to 7cbe36c Compare

August 29, 2020 15:12

@crisbeto


 fix(material/autocomplete): form control being marked as touched too ...

8d0658d

...early when clicking on an option
Currently we mark the autocomplete form control as touched on every blur event. This can
be an issue for the case where a control is being validated on blur, because the input
becomes blurred as soon as the user has their pointer down on something else
(e.g. one of the options). This will cause validation to run before the value has been
assigned. With these changes we switch to marking the control as touched once the
panel has been closed.
Fixes angular#11903.

@crisbeto crisbeto force-pushed the 11903/autocomplete-mark-as-touched branch from 7cbe36c to 8d0658d Compare

October 12, 2020 21:39

@annieyw

Copy link

Contributor

annieyw commented Oct 14, 2020 •

edited by josephperrott

Loading

Failing a number of google3 tests because tests were testing for errors on blur. Will probably have to individually change the tests to actually touch the form control.