Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(schematics): rewrite projectFromRc and add spec file #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nontangent wants to merge 3 commits into angular:main
base: main
Choose a base branch
Loading
from nontangent:fix/project-from-rc-bug

Conversation

Copy link

@nontangent nontangent commented Nov 4, 2022 •
edited
Loading

Checklist

Description

Fix #3077 and add unit tests.

Code sample

No API changes.

asithade and kingpeti reacted with thumbs up emoji
Copy link

google-cla bot commented Nov 4, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nontangent nontangent marked this pull request as ready for review November 4, 2022 06:04
Copy link
Author

I've just signed CLA.

@davideast davideast self-requested a review June 23, 2023 15:10
@davideast davideast self-assigned this Jun 23, 2023
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nontangent Thank you so much for this contribution and I apologize for how late it took us to get to it. I'll need to test through one a bit thoroughly myself so hang tight.

nontangent reacted with thumbs up emoji
Copy link

I think this would fix #3309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideast davideast davideast approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code in schematics/deploy/builder.ts is preventing the usage of any non-default firebaseProject and firebaseHostingSite values

AltStyle によって変換されたページ (->オリジナル) /