Fix #3098 #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

fr-esco wants to merge 5 commits into angular:main

from fr-esco:fix-3098

Open

Fix #3098 #3274

fr-esco wants to merge 5 commits into angular:main from fr-esco:fix-3098

Conversation

fr-esco

Copy link

@fr-esco fr-esco commented Oct 7, 2022

Checklist

Issue number for this PR: spawn gcloud ENOENT #3098
Docs included?: No
Test units included?: No
In a clean directory, yarn install, yarn test run successfully? Yes

Description

Running the deploy schematic on Windows:

Child processes that need gcloud cannot properly locate it;
The path to main.js is printed escaped by \\ instead of /, even though target runtime is Linux based.

Code sample

N. A.

fr-esco added 3 commits

October 7, 2022 15:38

@fr-esco


 fix(schematics): deploy - give child processes proper access to env v...

9337c7d

...ars (angular#3098)

@fr-esco


 fix(schematics): deploy - fix path to main.js ( angular#3098 )

6836b4d

@fr-esco


 Merge branch 'master' into fix-3098

d817a7f

davideast

davideast reviewed

Jun 23, 2023

View reviewed changes

Copy link

Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fr-esco Thank you so much and our apologies for taking so long to get to it. Since this is an older PR and there are a lot of merging PRs in flight it's going to take a bit to get this tested and merged so hang tight.