-
Notifications
You must be signed in to change notification settings - Fork 11.9k
test: migrate build and misc E2E tests to Puppeteer #32184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
+234
−345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@clydin
clydin
added
the
target: minor
This PR is targeted for the next minor release
label
Dec 19, 2025
Replaces the Protractor-based `ng e2e` execution with the new Puppeteer `executeBrowserTest` utility in various build and misc E2E tests. The following tests were updated: - express-engine-csp-nonce - express-engine-ngmodule - express-engine-standalone - app-shell-with-service-worker - auto-csp - worker - trusted-types This migration involves implementing custom `checkFn` logic to replicate the assertions previously handled by Protractor, such as verifying server-rendered content, console logs, and service worker states.
@clydin
clydin
force-pushed
the
e2e/protractor-convert-3
branch
from
December 19, 2025 21:12
397abf5 to
9cf0b71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the Protractor-based
ng e2eexecution with the new PuppeteerexecuteBrowserTestutility in various build and misc E2E tests.The following tests were updated:
This migration involves implementing custom
checkFnlogic to replicate the assertions previously handled by Protractor, such as verifying server-rendered content, console logs, and service worker states.