-
Notifications
You must be signed in to change notification settings - Fork 11.9k
test: migrate i18n E2E tests to Puppeteer #32183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
+93
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@clydin
clydin
added
the
target: minor
This PR is targeted for the next minor release
label
Dec 19, 2025
Replaces the Protractor-based `ng e2e` execution with the new Puppeteer `executeBrowserTest` utility in the i18n E2E test suite. Refactors `setup.ts` to export a `browserCheck` helper function for verifying translated content, and removes the legacy Protractor spec file generation and configuration. Updates the following tests to use the new infrastructure: - ivy-localize-es2015-e2e - ivy-localize-basehref - ivy-localize-es2015 - ivy-localize-locale-data-augment - ivy-localize-sub-path
@clydin
clydin
force-pushed
the
e2e/protractor-convert-2
branch
from
December 19, 2025 18:34
a63c2be to
8ac5d11
Compare
@clydin
clydin
added
the
action: review
The PR is still awaiting reviews from at least one requested reviewer
label
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the Protractor-based
ng e2eexecution with the new PuppeteerexecuteBrowserTestutility in the i18n E2E test suite.Refactors
setup.tsto export abrowserCheckhelper function for verifying translated content, and removes the legacy Protractor spec file generation and configuration.Updates the following tests to use the new infrastructure: