-
Notifications
You must be signed in to change notification settings - Fork 11.9k
fix(@angular/build): allow disabling sourcemaps in the dev server #31510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
+107
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alan-agius4
alan-agius4
force-pushed
the
vite-sourcemap
branch
from
October 17, 2025 12:16
13b6782 to
5038325
Compare
@alan-agius4
alan-agius4
added
the
target: patch
This PR is targeted for the next patch release
label
Oct 17, 2025
@alan-agius4
alan-agius4
force-pushed
the
vite-sourcemap
branch
2 times, most recently
from
October 17, 2025 14:01
ad6d712 to
934f57f
Compare
This change introduces the ability to disable sourcemaps when running the development server. A new Vite plugin has been added to remove sourcemap comments from generated assets. The dev server's configuration has been updated to conditionally apply this plugin and control CSS sourcemap generation based on the project's sourceMap setting. Closes angular#31331
@alan-agius4
alan-agius4
force-pushed
the
vite-sourcemap
branch
from
October 20, 2025 07:40
934f57f to
fc7b18f
Compare
AlonMiz
AlonMiz
reviewed
Nov 2, 2025
import type { Plugin } from 'vite';
export const removeSourceMapsPlugin: Plugin = {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't "remove sourcemaps" wasteful? meaning the bundler already generated and the cpu/memory resources are wasted. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the ability to disable sourcemaps when running the development server.
A new Vite plugin has been added to remove sourcemap comments from generated assets. The dev server's configuration has been updated to conditionally apply this plugin and control CSS sourcemap generation based on the project's sourceMap setting.
Closes #31331