Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

docs: fix up createNodeRequestHandler examples #31324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@gioboa gioboa commented Sep 27, 2025

Thanks for this great project 🙏
I updated the examples for createNodeRequestHandler because I copied and pasted them and found some typos.

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the area: docs Related to the documentation label Sep 27, 2025
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you kindly squash the commits?

gioboa reacted with thumbs up emoji
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Sep 27, 2025
@gioboa gioboa force-pushed the docs/createNodeRequestHandler-example branch from 26b826e to 09d505d Compare September 27, 2025 14:15
Copy link
Contributor Author

gioboa commented Sep 27, 2025

LGTM, can you kindly squash the commits?

Done 👍
alan-agius4 reacted with hooray emoji

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 27, 2025
@alan-agius4 alan-agius4 merged commit 3db1a17 into angular:main Sep 29, 2025
32 checks passed
Copy link
Collaborator

This PR was merged into the repository. The changes were merged into the following branches:
gioboa reacted with thumbs up emoji

@gioboa gioboa deleted the docs/createNodeRequestHandler-example branch September 29, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /