-
Notifications
You must be signed in to change notification settings - Fork 11.9k
feat(@angular/ssr): introduce BootstrapContext for isolated server-side rendering #31108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+471
−501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@angular-robot
angular-robot
bot
added
detected: feature
PR contains a feature commit
area: @angular/ssr
labels
Sep 3, 2025
@alan-agius4
alan-agius4
added
the
target: patch
This PR is targeted for the next patch release
label
Sep 3, 2025
@alan-agius4
alan-agius4
changed the title
(削除) feat(@angular/ssr): adopt
(追記) fix(@angular/ssr): adopt Sep 3, 2025
bootstrapServerApplication
for streamlined server bootstrap (削除ここまで)bootstrapServerApplication
for streamlined server bootstrap (追記ここまで)
@alan-agius4
alan-agius4
removed
the
detected: feature
PR contains a feature commit
label
Sep 3, 2025
@alan-agius4
alan-agius4
force-pushed
the
server-app-bootstrap
branch
from
September 3, 2025 09:20
8aecc3f
to
779a0bd
Compare
@alan-agius4
alan-agius4
added
the
action: review
The PR is still awaiting reviews from at least one requested reviewer
label
Sep 3, 2025
@alan-agius4
alan-agius4
force-pushed
the
server-app-bootstrap
branch
from
September 3, 2025 11:32
779a0bd
to
750ae71
Compare
jkrems
jkrems
approved these changes
Sep 3, 2025
@alan-agius4
alan-agius4
added
target: major
This PR is targeted for the next major release
and removed
target: patch
This PR is targeted for the next patch release
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Sep 3, 2025
@alan-agius4
alan-agius4
changed the title
(削除) fix(@angular/ssr): adopt
(追記) feat(@angular/ssr): introduce BootstrapContext for isolated server-side rendering (追記ここまで)
Sep 9, 2025
bootstrapServerApplication
for streamlined server bootstrap (削除ここまで) @alan-agius4
alan-agius4
force-pushed
the
server-app-bootstrap
branch
from
September 9, 2025 07:29
750ae71
to
a81c176
Compare
@angular-robot
angular-robot
bot
added
detected: breaking change
PR contains a commit with a breaking change
detected: feature
PR contains a feature commit
labels
Sep 9, 2025
@alan-agius4
alan-agius4
force-pushed
the
server-app-bootstrap
branch
2 times, most recently
from
September 9, 2025 08:10
46866eb
to
66cf119
Compare
jkrems
jkrems
approved these changes
Sep 9, 2025
@alan-agius4
alan-agius4
added
target: patch
This PR is targeted for the next patch release
target: rc
This PR is targeted for the next release-candidate
and removed
target: major
This PR is targeted for the next major release
target: patch
This PR is targeted for the next patch release
target: rc
This PR is targeted for the next release-candidate
labels
Sep 9, 2025
@alan-agius4
alan-agius4
added
target: minor
This PR is targeted for the next minor release
target: major
This PR is targeted for the next major release
and removed
target: minor
This PR is targeted for the next minor release
labels
Sep 9, 2025
@angular-robot
angular-robot
bot
added
the
area: build & ci
Related the build and CI infrastructure of the project
label
Sep 10, 2025
jkrems
jkrems
approved these changes
Sep 10, 2025
@alan-agius4
alan-agius4
force-pushed
the
server-app-bootstrap
branch
2 times, most recently
from
September 10, 2025 15:25
8fb78d1
to
ff31f07
Compare
@alan-agius4
alan-agius4
added
action: merge
The PR is ready for merge by the caretaker
and removed
state: blocked
labels
Sep 10, 2025
@alan-agius4
alan-agius4
force-pushed
the
server-app-bootstrap
branch
from
September 10, 2025 15:31
ff31f07
to
487986e
Compare
@alan-agius4
alan-agius4
force-pushed
the
server-app-bootstrap
branch
2 times, most recently
from
September 10, 2025 16:11
44b8cd2
to
2e2140a
Compare
...de rendering This commit introduces a number of changes to the server bootstrapping process to make it more robust and less error-prone, especially for concurrent requests. Previously, the server rendering process relied on a module-level global platform injector. This could lead to issues in server-side rendering environments where multiple requests are processed concurrently, as they could inadvertently share or overwrite the global injector state. The new approach introduces a `BootstrapContext` that is passed to the `bootstrapApplication` function. This context provides a platform reference that is scoped to the individual request, ensuring that each server-side render has an isolated platform injector. This prevents state leakage between concurrent requests and makes the overall process more reliable. BREAKING CHANGE: The server-side bootstrapping process has been changed to eliminate the reliance on a global platform injector. Before: ```ts const bootstrap = () => bootstrapApplication(AppComponent, config); ``` After: ```ts const bootstrap = (context: BootstrapContext) => bootstrapApplication(AppComponent, config, context); ```
See associated pull request for more information.
@alan-agius4
alan-agius4
force-pushed
the
server-app-bootstrap
branch
from
September 10, 2025 16:31
2e2140a
to
c22f850
Compare
@alan-agius4
alan-agius4
merged commit Sep 10, 2025
32b9fe9
into
angular:main
41 of 42 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This commit introduces a number of changes to the server bootstrapping process to make it more robust and less error-prone, especially for concurrent requests.
Previously, the server rendering process relied on a module-level global platform injector. This could lead to issues in server-side rendering environments where multiple requests are processed concurrently, as they could inadvertently share or overwrite the global injector state.
The new approach introduces a
BootstrapContext
that is passed to thebootstrapApplication
function. This context provides a platform reference that is scoped to the individual request, ensuring that each server-side render has an isolated platform injector. This prevents state leakage between concurrent requests and makes the overall process more reliable.BREAKING CHANGE:
The server-side bootstrapping process has been changed to eliminate the reliance on a global platform injector.
Before:
After: