-
Notifications
You must be signed in to change notification settings - Fork 11.9k
refactor(@angular/build): improve error handling for unit-test builder setup #30945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...r setup Error handling has been enhanced to provide more actionable feedback for common misconfigurations, such as an invalid `buildTarget` or a malformed test runner package.
Refactors the Vitest test runner to improve code organization and separation of concerns. The browser-specific helper functions (`findBrowserProvider`, `normalizeBrowserName`, and `setupBrowserConfiguration`) are moved from the main `executor.ts` file into a new, dedicated `browser-provider.ts` file. This cleanup allows the main executor to focus solely on its primary responsibility of managing the test execution lifecycle, while properly encapsulating the browser setup logic in a single, co-located file.
@clydin
clydin
added
the
target: major
This PR is targeted for the next major release
label
Aug 18, 2025
@clydin
clydin
force-pushed
the
unit-test/error-handling
branch
from
August 18, 2025 16:41
66f4607
to
793f102
Compare
@clydin
clydin
added
the
action: review
The PR is still awaiting reviews from at least one requested reviewer
label
Aug 18, 2025
...building The experimental unit-test builder will now pass through the `progress` option to the build system if present. By default the `progress` value of the build target will be used.
@clydin
clydin
force-pushed
the
unit-test/error-handling
branch
from
August 18, 2025 17:51
793f102
to
5107c51
Compare
alan-agius4
alan-agius4
approved these changes
Aug 19, 2025
@alan-agius4
alan-agius4
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Error handling has been enhanced to provide more actionable feedback for common misconfigurations, such as an invalid
buildTarget
or a malformed test runner package.The experimental unit-test builder will now pass through the
progress
optionto the build system if present. By default the
progress
value of the buildtarget will be used.
Closes #30865