Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

ci: re-enable windows CI [main] #30907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into angular:main from alan-agius4:try-use-ubuntu
Aug 14, 2025
Merged

Conversation

Copy link
Collaborator

@alan-agius4 alan-agius4 commented Aug 13, 2025 •
edited
Loading

@alan-agius4 alan-agius4 force-pushed the try-use-ubuntu branch 5 times, most recently from 2d242b3 to 0c0e931 Compare August 13, 2025 16:01
@alan-agius4 alan-agius4 changed the title (削除) Try use ubuntu (削除ここまで) (追記) Windows CI fix (追記ここまで) Aug 13, 2025
@alan-agius4 alan-agius4 force-pushed the try-use-ubuntu branch 7 times, most recently from 04726a6 to 1ceddef Compare August 13, 2025 19:17
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Aug 13, 2025
@alan-agius4 alan-agius4 changed the title (削除) Windows CI fix (削除ここまで) (追記) ci: re-enable window CI (追記ここまで) Aug 14, 2025
@alan-agius4 alan-agius4 added target: minor This PR is targeted for the next minor release and removed area: @schematics/angular area: @angular/cli area: build & ci Related the build and CI infrastructure of the project labels Aug 14, 2025
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 14, 2025
@alan-agius4 alan-agius4 marked this pull request as ready for review August 14, 2025 08:08
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

alan-agius4 reacted with heart emoji
- name: Install node modules in WSL (re-using from previous install/cache restore)
run: |
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
Copy link
Member

@devversion devversion Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Is this not installed from the bashrc?

Copy link
Collaborator Author

@alan-agius4 alan-agius4 Aug 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried placing them in the rc echo "[ -s \"$NVM_DIR/nvm.sh\" ] && \\. \"$NVM_DIR/nvm.sh\"" >> "$HOME/.bashrc" but I did not work.

Not sure what is wrong, I spent too much time on that and I gave up

- name: Install node modules in WSL (re-using from previous install/cache restore)
run: |
export NVM_DIR="$HOME/.nvm"
Copy link
Collaborator Author

@alan-agius4 alan-agius4 Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to be in every step otherwise pnpm and node are not loaded.

@alan-agius4 alan-agius4 changed the title (削除) ci: re-enable window CI (削除ここまで) (追記) ci: re-enable windows CI (追記ここまで) Aug 14, 2025
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 14, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Aug 14, 2025
@alan-agius4 alan-agius4 changed the title (削除) ci: re-enable windows CI (削除ここまで) (追記) ci: re-enable windows CI [main] (追記ここまで) Aug 14, 2025
@alan-agius4 alan-agius4 force-pushed the try-use-ubuntu branch 4 times, most recently from 5cad872 to 646bcca Compare August 14, 2025 10:00
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 14, 2025 
This commit fixes and re-enables windows CI.
Upstream fixes:
- devversion/rules_browsers#18
- angular/dev-infra#2966
@alan-agius4 alan-agius4 merged commit c8a103b into angular:main Aug 14, 2025
30 checks passed
@alan-agius4 alan-agius4 deleted the try-use-ubuntu branch August 14, 2025 10:51
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /