-
Notifications
You must be signed in to change notification settings - Fork 11.9k
refactor(@angular/cli): add a get Zoneless/OnPush MCP tool #30868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,086
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@atscott
atscott
force-pushed
the
zoneless-migration-mcp
branch
4 times, most recently
from
August 13, 2025 22:45
3e10340
to
f336ca0
Compare
clydin
clydin
reviewed
Aug 20, 2025
packages/angular/cli/src/commands/mcp/tools/onpush-zoneless-migration/zoneless-migration.ts
Outdated
Show resolved
Hide resolved
packages/angular/cli/src/commands/mcp/tools/onpush-zoneless-migration/zoneless-migration.ts
Outdated
Show resolved
Hide resolved
packages/angular/cli/src/commands/mcp/tools/onpush-zoneless-migration/zoneless-migration.ts
Outdated
Show resolved
Hide resolved
packages/angular/cli/src/commands/mcp/tools/onpush-zoneless-migration/migrate_test_file.ts
Outdated
Show resolved
Hide resolved
packages/angular/cli/src/commands/mcp/tools/onpush-zoneless-migration/migrate_test_file.ts
Outdated
Show resolved
Hide resolved
packages/angular/cli/src/commands/mcp/tools/onpush-zoneless-migration/ts_utils.ts
Outdated
Show resolved
Hide resolved
Closed
2 tasks
@atscott
atscott
force-pushed
the
zoneless-migration-mcp
branch
8 times, most recently
from
August 28, 2025 03:01
0565a59
to
d9015cf
Compare
This change adds a tool that identifies the next steps for migrating a project file or directory to Zoneless or OnPush. The priorities for migration are: 1. Find and report any unsupported uses of ZoneJS APIs. These are easily verifiable. If they exist, they need to be removed and the tool provides suggested replacements 2. Provide requirements for OnPush compatibility for any files with a Component. It is suggested to use an explicit `ChangeDetectionStrategy.Default` until it can be verified the migration is complete. The tool skips any components with explicit change detection strategy definitions. This is required since we have no way of statically verifying a component is compatible with OnPush, so we need some way to indicate the tool should move on from a component 3. When nothing is identified in the above two steps, move on to test files and suggest migrating those to use zoneless. This is the best method to verify that components are zoneless compatible.
@atscott
atscott
force-pushed
the
zoneless-migration-mcp
branch
from
August 28, 2025 03:06
d9015cf
to
d091c89
Compare
clydin
clydin
approved these changes
Aug 28, 2025
@atscott
atscott
added
action: merge
The PR is ready for merge by the caretaker
target: patch
This PR is targeted for the next patch release
labels
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a tool that identifies the next steps for migrating a project file or directory to Zoneless or OnPush. The priorities for migration are:
ChangeDetectionStrategy.Default
until it can be verified the migration is complete. The tool skips any components with explicit change detection strategy definitions. This is required since we have no way of statically verifying a component is compatible with OnPush, so we need some way to indicate the tool should move on from a component