-
Notifications
You must be signed in to change notification settings - Fork 11.9k
fix(@angular-devkit/build-angular): expand jest and jest-environment-jsdom to allow version 30
#30761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
acfec5c to
8cc3187
Compare
jest and jest-environment-jsdom to allow version 30 (削除ここまで)jest and jest-environment-jsdom to allow version 30 (追記ここまで)
...nt-jsdom` to allow version 30 This commit expands the peer deps of these dependencies to allow version 30. Closes angular#30760
8cc3187 to
4186d3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Do we need to continue to support v29? Since this is still experimental, I don't think we're on the hook for backwards compatibility yet and it's probably reasonable to limit this to the latest major unless we have reason to believe that will be exceptionally difficult for users to adopt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it seems that this would need further investigation to get version 30 to work. Let's have a chat about this offline to see the next steps for this builder.
swierzbicki
commented
Jul 28, 2025
@dgp1130 @alan-agius4 When support for Jest v30 could be merged?
This would require some further investigation and work to land as some tests are failing with the latest jest version.
swierzbicki
commented
Aug 1, 2025
@alan-agius4 Sure. I understand that. But the question is - when?
Are we talking about days, weeks.....months? 🤔
It would be nice to know what are the plans for that support :) Don't want to check this PR every day :D
kstrasters-pj
commented
Aug 1, 2025
@alan-agius4 Sure. I understand that. But the question is - when? Are we talking about days, weeks.....months? 🤔
It would be nice to know what are the plans for that support :) Don't want to check this PR every day :D
on the right there is a "Subscribe" button where you can opt in to getting updates on the status and comments of this PR to avoid having to check manually.
with that being said a timeline would be pretty cool as this is holding up my teams update to Jest 30 =)
We haven't had a detailed investigation or discussion just yet. When we have more information to share, we'll share it.
Also just a friendly reminder that the @angular-devkit/build-angular:jest builder is still experimental. We appreciate devs trying it out and giving feedback, but it is not recommended for load-bearing development workflows at this time.
We haven't had a detailed investigation or discussion just yet. When we have more information to share, we'll share it.
Also just a friendly reminder that the
@angular-devkit/build-angular:jestbuilder is still experimental. We appreciate devs trying it out and giving feedback, but it is not recommended for load-bearing development workflows at this time.
I understand this to be a sensible statement, but even the @angular-devkit/build-angular has a peerDependency on 29.5.
Is y'all expectation that if we want to use Jest with our Angular projects that we would need to have Jest installed completely separately from the Angular project as a whole?
guoliang
commented
Sep 4, 2025
For anyone still waiting on this PR, you can also switch to @angular/build
it11ah1
commented
Sep 12, 2025
For anyone still waiting on this PR, you can also switch to
@angular/build
Not if it comes through another package (like @storybook/angular). In that case, overrides can help — but it’s a bit dirty...
This commit expands the peer deps of these dependencies to allow version 30.
Closes #30760