-
Notifications
You must be signed in to change notification settings - Fork 11.9k
feat(@angular-devkit/build-angular): karma-coverage w/ app builder #28509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@angular-robot
angular-robot
bot
added
detected: feature
PR contains a feature commit
area: @angular-devkit/build-angular
labels
Sep 26, 2024
@jkrems
jkrems
changed the title
(ει€) Jk-ill-cover-you (ει€γγγΎγ§)
(θΏ½θ¨) feat(@angular-devkit/build-angular): karma-coverage w/ app builder (θΏ½θ¨γγγΎγ§)
Sep 26, 2024
@jkrems
jkrems
force-pushed
the
jk-ill-cover-you
branch
2 times, most recently
from
September 27, 2024 15:02
13840aa
to
00bb941
Compare
@jkrems
jkrems
added
target: feature
This PR is targeted for a feature branch (outside of main and semver branches)
target: minor
This PR is targeted for the next minor release
action: review
The PR is still awaiting reviews from at least one requested reviewer
and removed
target: feature
This PR is targeted for a feature branch (outside of main and semver branches)
labels
Sep 27, 2024
clydin
clydin
approved these changes
Sep 27, 2024
packages/angular/build/src/tools/esbuild/javascript-transformer-worker.ts
Outdated
Show resolved
Hide resolved
@jkrems
jkrems
force-pushed
the
jk-ill-cover-you
branch
from
September 27, 2024 17:57
00bb941
to
0f39943
Compare
@jkrems
jkrems
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Sep 27, 2024
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
@angular-automatic-lock-bot
angular-automatic-lock-bot
bot
locked and limited conversation to collaborators
Oct 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Tasks to Cover (π₯)
istanbul-lib-instrument
and not the one thatkarma-coverage
depends on.Implementation Notes
packages/angular/build/src/tools/babel/plugins/*
are 1:1 copies of files already present inpackages/angular_devkit/build_angular/src/tools/babel/plugins/*
. I couldn't find a clean way to prevent that. Either @angular/build have to expose the plugin inpackage.json#exports
or it would have to depend on @angular-devkit/build-angular. Both seemed undesirable.Historical Notes
Approaches that didn't work:
karma-coverage
really doesn't want to filter data from coverage data after the fact. Not to mention that it could be fairly expensive to send that data back to the karma process if it's then just discarded.karma-coverage
's built-in preprocessor. The outdated instrumentation code it's using doesn't handle async function correctly and gives bad function coverage data because of it.Things that could've worked: