Commit d4ee360

clydinalan-agius4

authored and

committed

fix(@angular/build): keep background referenced HMR update chunks

When HMR is enabled and a component update is sent to the development server, the following background incremental update will no longer remove the previous JavaScript chunk files for lazy routes. This allows the active and running application code within the browser to still access the lazy chunks referenced in the code. This is important for cases such as when a component in a lazy route (that has not yet been accessed) is modified. In this case, the component update is still processed if/when the lazy route is eventually accessed via the module-time evaluation of the component update code.

1 parent cae068b commit d4ee360Copy full SHA for d4ee360

File tree

1 file changed

-0

lines changed

packages/angular/build/src/builders/application
- build-action.ts

1 file changed

-0

lines changed

`‎packages/angular/build/src/builders/application/build-action.ts‎`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -358,6 +358,15 @@ function* emitOutputResults(`
`358`	`358`	`};`
`359`	`359`	`}`
`360`	`360`
	`361`	`+ // Do not remove stale files yet if there are template updates.`
	`362`	`+ // Component chunk files may still be referenced in running browser code.`
	`363`	`+ // Module evaluation time component updates will update any of these files.`
	`364`	`+ // This typically occurs when a lazy component is changed that has not yet`
	`365`	`+ // been accessed at runtime.`
	`366`	`+ if (hasTemplateUpdates && incrementalResult.background) {`
	`367`	`+ removedOutputFiles.clear();`
	`368`	`+ }`
	`369`	`+`
`361`	`370`	`// Include the removed output and asset files`
`362`	`371`	`incrementalResult.removed.push(`
`363`	`372`	`...Array.from(removedOutputFiles, ([file, { type }]) => ({`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit d4ee360

File tree

1 file changed

1 file changed

`‎packages/angular/build/src/builders/application/build-action.ts‎`

0 commit comments