Commit cae068b

committed

fix(@schematics/angular): update library schematic to use @angular-devkit/build-angular:ng-packagr

The library schematic currently relies on Karma, which requires `@angular-devkit/build-angular` to be installed. To address this, we now use the `ng-packagr` builder provided in this package. Closes #29494

1 parent f743a63 commit cae068bCopy full SHA for cae068b

File tree

2 files changed

-4

lines changed

packages/schematics/angular/library
- index.ts
- index_spec.ts

2 files changed

-4

lines changed

`‎packages/schematics/angular/library/index.ts‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,8 @@ function addDependenciesToPackageJson() {`
`53`	`53`	`},`
`54`	`54`	`{`
`55`	`55`	`type: NodeDependencyType.Dev,`
`56`		`- name: '@angular/build',`
`57`		`- version: latestVersions.AngularBuild,`
	`56`	`+ name: '@angular-devkit/build-angular',`
	`57`	`+ version: latestVersions.DevkitBuildAngular,`
`58`	`58`	`},`
`59`	`59`	`{`
`60`	`60`	`type: NodeDependencyType.Dev,`
`@@ -91,7 +91,7 @@ function addLibToWorkspaceFile(`
`91`	`91`	`prefix: options.prefix,`
`92`	`92`	`targets: {`
`93`	`93`	`build: {`
`94`		`- builder: Builders.BuildNgPackagr,`
	`94`	`+ builder: Builders.NgPackagr,`
`95`	`95`	`defaultConfiguration: 'production',`
`96`	`96`	`options: {`
`97`	`97`	project: `${projectRoot}/ng-package.json`,

`‎packages/schematics/angular/library/index_spec.ts‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -388,7 +388,9 @@ describe('Library Schematic', () => {`
`388`	`388`	`const tree = await schematicRunner.runSchematic('library', defaultOptions, workspaceTree);`
`389`	`389`
`390`	`390`	`const workspace = JSON.parse(tree.readContent('/angular.json'));`
`391`		`- expect(workspace.projects.foo.architect.build.builder).toBe('@angular/build:ng-packagr');`
	`391`	`+ expect(workspace.projects.foo.architect.build.builder).toBe(`
	`392`	`+ '@angular-devkit/build-angular:ng-packagr',`
	`393`	`+ );`
`392`	`394`	`});`
`393`	`395`
`394`	`396`	`describe('standalone=false', () => {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit cae068b

File tree

2 files changed

2 files changed

`‎packages/schematics/angular/library/index.ts‎`

`‎packages/schematics/angular/library/index_spec.ts‎`

0 commit comments