This repository was archived by the owner on Oct 2, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(uiSelectHeaderGroupSelectableDirective): do not issue error if feature is disabled; apply selectable feature after options list changed/filtered; do not select unnamed group #2069
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ature is disabled, but directive exists on template
...e feature after options list has changed
@Klinton90
Klinton90
changed the title
(削除) fix(uiSelectHeaderGroupSelectableDirective): do not issue error if feature is disabled (削除ここまで)
(追記) fix(uiSelectHeaderGroupSelectableDirective): do not issue error if feature is disabled and apply selectable feature after options list changed/filtered (追記ここまで)
Oct 25, 2017
Contributor
DarkIsDude
commented
Oct 26, 2017
Hi @Klinton90 , look good to me 👍 .
...roup without header
@Klinton90
Klinton90
changed the title
(削除) fix(uiSelectHeaderGroupSelectableDirective): do not issue error if feature is disabled and apply selectable feature after options list changed/filtered (削除ここまで)
(追記) fix(uiSelectHeaderGroupSelectableDirective): do not issue error if feature is disabled; apply selectable feature after options list changed/filtered; do not select unnamed group (追記ここまで)
Oct 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Trying to use new feature on my project. Would like to fix issues as soon as I find it.
We use wrapper around ui-select, so we always need
uiSelectHeaderGroupSelectableDirectivedirective to exist on template even when ui-select is used forsingle/no-groupsmode. In current implementation, if directive is disabled and other conditions do not pass,console.error()will be executed. That fix prevents error message to be shown for disabled directive.If list of available options is filtered on the fly (based on
$select.search, e.g.ng-repeat="options | filter: $select.search"), not all group headers receiveui-select-header-group-selectableclass, as DOM is updated afterenableClick()function runs.Do not add click listener to unnamed group