Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat (*): Add i18n support #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stherrienaspnet wants to merge 23 commits into angular-fullstack:master
base: master
Choose a base branch
Loading
from stherrienaspnet:i18nSupport

Conversation

Copy link
Collaborator

@stherrienaspnet stherrienaspnet commented Apr 5, 2017 •
edited
Loading

Add i18n support (multi-language) using angular-translate.

Copy link
Contributor

Not sure how we merge in this project, but looks to me your commits don't follow the convention:
-AngularJS commit message guidelines

Copy link
Collaborator Author

Can i change the PR text without cancelling it?

Copy link
Collaborator Author

I really your PR about warnings 😊
benmarten reacted with thumbs up emoji

Copy link
Contributor

If you mean how to rename your commits, look into 'git rebase -i HEAD~1'. the force pushing your local branch to remote, i guess ;)
Renaming the PR itself should be possible here on GitHub itself...

Copy link
Collaborator Author

I forgot a word in my last posy , i mean I really your PR who fix warning message :)

Copy link
Collaborator Author

The missing word is like

Copy link
Contributor

Check out this cli tool for commit messages: https://github.com/commitizen/cz-cli

Copy link
Collaborator Author

stherrienaspnet commented Apr 9, 2017 via email

Thanks Ben! Le 8 avr. 2017 12:41 PM, "Ben Marten" <notifications@github.com> a écrit :
...
Check out this cli tool for commit messages: https://github.com/commitizen/cz-cli — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2534 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF19cfMUZbnm9u1--Fdqca-HkZoH3aWfks5rt7jMgaJpZM4M0MLN> .

@Awk34 Awk34 self-requested a review April 10, 2017 04:16
@@ -189,6 +189,11 @@ export class Generator extends Base {
filter: val => val.toLowerCase()
}, {
type: 'confirm',
name: 'i18nSupport',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be simpler to just call it i18n

Copy link

Ghalleb commented Jun 23, 2017

I would really appreciate to have i8n support...

Copy link

is this working in the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awk34 Awk34 Awk34 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /