-
Notifications
You must be signed in to change notification settings - Fork 51
Open
Conversation
andyleap
commented
Nov 30, 2016
Owner
Hey, that's awesome!
I'll look at getting it merged, but it looks like I'll need to change everything back to github.com/andyleap/gencode
zakattacktaylor
commented
Nov 30, 2016
Author
Yeah, not sure how you work on a fork in golang without changing the imports. I totally didn't want to.
andyleap
commented
Nov 30, 2016
Owner
Standard recommendation is to do a go get to grab the original, then navigate in an do a git add remote mine <github clone path> to add your fork as a remote, then push to that remote.
zakattacktaylor
commented
Nov 30, 2016
Author
Cool, thanks, but then no one else could use the code I am pushing, it would only work on my machine. Anyways, its easy for me to search and replace once everything is cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Just wanted to give you a look at some C++ additions I added to gencode. Also, I implemented golang maps and nested slices.
Its in a rough state, no tests or anything, but thought you might enjoy seeing it.
We really like gencode, its fast and the golang code is nice and clean (simple structs not a odd API to write with).
Thanks!
Zak