Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

maps and c++ support.#12

Open
zakattacktaylor wants to merge 4 commits into
andyleap:master from
eyrie-io:master
Open

maps and c++ support. #12
zakattacktaylor wants to merge 4 commits into
andyleap:master from
eyrie-io:master

Conversation

@zakattacktaylor

@zakattacktaylor zakattacktaylor commented Nov 30, 2016

Copy link
Copy Markdown

Hi,

Just wanted to give you a look at some C++ additions I added to gencode. Also, I implemented golang maps and nested slices.

Its in a rough state, no tests or anything, but thought you might enjoy seeing it.

We really like gencode, its fast and the golang code is nice and clean (simple structs not a odd API to write with).

Thanks!
Zak

Copy link
Copy Markdown
Owner

Hey, that's awesome!

I'll look at getting it merged, but it looks like I'll need to change everything back to github.com/andyleap/gencode

Copy link
Copy Markdown
Author

Yeah, not sure how you work on a fork in golang without changing the imports. I totally didn't want to.

Copy link
Copy Markdown
Owner

Standard recommendation is to do a go get to grab the original, then navigate in an do a git add remote mine <github clone path> to add your fork as a remote, then push to that remote.

Copy link
Copy Markdown
Author

Cool, thanks, but then no one else could use the code I am pushing, it would only work on my machine. Anyways, its easy for me to search and replace once everything is cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /