-
Notifications
You must be signed in to change notification settings - Fork 51
Open
Conversation
andyleap
commented
Oct 25, 2016
Owner
I can see the usefulness of this, but my issue is that it makes it an all or nothing thing. Either the whole schema is bigendian, or none of it is. I'd rather add additional types for bigendian, or some kind of modifier similar to the "framed" modifier for structs, so that it can be enabled on a "as needed" basis
octo47
commented
Oct 27, 2016
Author
yeah, sounds good.
will take a look on how that can be done.
thanks.
sylvainr
commented
Dec 31, 2020
FYI I ported @octo47's BigEndian support PR to be more easily accessible at https://github.com/sylvainr/gencode-bigendian.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently ints and floats encoded in little endian.
in some cases it is preferred to have bigendian (for example for encoding keys for leveldb like databases).
here is a small patch that adds flag to generate bigendian encoding.