-
Notifications
You must be signed in to change notification settings - Fork 160
Open
Conversation
Merge pull request #87 from android/support_video_playback_from_internet Video playback support via network
...layback_latency_metrics
...layback_latency_metrics
...layback_latency_metrics
...layback_latency_metrics
MayuriKhinvasara
commented
Aug 6, 2024
Contributor
Author
@calren there were some spotless errors, rectified it. This is ready for review. This PR is just an incremental step in adding a preload manager
calren
calren
reviewed
Aug 6, 2024
override fun onRenderedFirstFrame() {
super.onRenderedFirstFrame()
val timeToFirstRenderFrame = System.currentTimeMillis() - timeAtPlayerPrepare
// Use this value in future to compare performance with and without preload manager
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be useful to add a log statement here to print out this value?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Added a log statement
calren
calren
approved these changes
Aug 6, 2024
@calren
calren
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just small suggestion about adding log statement so we utilize timeToFirstRenderFrame
...layback_latency_metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measure time taken to render the first frame by the player.