-
Notifications
You must be signed in to change notification settings - Fork 335
Comments
Added snippets for Media3 Inspector module and update Media3 version to 1.9.0-alpha01#719
Open
amanc3765 wants to merge 4 commits intoandroid:main from
Open
Added snippets for Media3 Inspector module and update Media3 version to 1.9.0-alpha01 #719amanc3765 wants to merge 4 commits intoandroid:main from
amanc3765 wants to merge 4 commits intoandroid:main from
Conversation
Here is the summary of changes.
You are about to add 14 region tags.
- misc/src/main/java/com/example/snippets/InspectorModuleJavaSnippets.java:57, tag
android_dev_retriever_media3_java - misc/src/main/java/com/example/snippets/InspectorModuleJavaSnippets.java:85, tag
android_migration_retriever_platform_java - misc/src/main/java/com/example/snippets/InspectorModuleJavaSnippets.java:98, tag
android_migration_retriever_media3_java - misc/src/main/java/com/example/snippets/InspectorModuleJavaSnippets.java:127, tag
android_dev_frame_media3_java - misc/src/main/java/com/example/snippets/InspectorModuleJavaSnippets.java:150, tag
android_migration_frame_platform_java - misc/src/main/java/com/example/snippets/InspectorModuleJavaSnippets.java:166, tag
android_migration_frame_media3_java - misc/src/main/java/com/example/snippets/InspectorModuleJavaSnippets.java:189, tag
android_dev_extractor_media3_java - misc/src/main/java/com/example/snippets/InspectorModuleKotlinSnippets.kt:43, tag
android_dev_retriever_media3_kotlin - misc/src/main/java/com/example/snippets/InspectorModuleKotlinSnippets.kt:61, tag
android_migration_retriever_platform_kotlin - misc/src/main/java/com/example/snippets/InspectorModuleKotlinSnippets.kt:76, tag
android_migration_retriever_media3_kotlin - misc/src/main/java/com/example/snippets/InspectorModuleKotlinSnippets.kt:97, tag
android_dev_frame_media3_kotlin - misc/src/main/java/com/example/snippets/InspectorModuleKotlinSnippets.kt:115, tag
android_migration_frame_platform_kotlin - misc/src/main/java/com/example/snippets/InspectorModuleKotlinSnippets.kt:137, tag
android_migration_frame_media3_kotlin - misc/src/main/java/com/example/snippets/InspectorModuleKotlinSnippets.kt:156, tag
android_dev_extractor_media3_kotlin
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:
- Refresh this comment
@srikrishnasakunia
srikrishnasakunia
requested a review
from MayuriKhinvasara
December 5, 2025 05:20
MayuriKhinvasara
MayuriKhinvasara
approved these changes
Dec 9, 2025
@MayuriKhinvasara
MayuriKhinvasara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one minor change.
misc/src/main/java/com/example/snippets/InspectorModuleJavaSnippets.java
Outdated
Show resolved
Hide resolved
@amanc3765
amanc3765
requested review from
MayuriKhinvasara,
kkuan2011,
srikrishnasakunia and
yrezgui
December 9, 2025 10:05
srikrishnasakunia
srikrishnasakunia
approved these changes
Dec 12, 2025
srikrishnasakunia
srikrishnasakunia
approved these changes
Dec 12, 2025
@amanc3765
amanc3765
force-pushed
the
media3-inspector-snippets
branch
from
December 12, 2025 08:36
f8c3988 to
7ca3fbb
Compare
kkuan2011
kkuan2011
approved these changes
Feb 12, 2026
Contributor
@kkuan2011
kkuan2011
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed review, missed this PR! Can you rebase? Then feel free to merge, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Kotlin and Java snippets for following classes in Media3 Inspector module:
These snippets will be added to DAC in a separate CL.
Also bumped Media3 version to
1.9.0-alpha01to use this new module.