-
Notifications
You must be signed in to change notification settings - Fork 336
feat(views): Add basic notification snippet#631
feat(views): Add basic notification snippet #631askandroid wants to merge 3 commits intoandroid:main from
Conversation
Add a basic notification snippet and associated files to the views module. Region-Tag: android_views_notifications_build_basic
Here is the summary of changes.
You are about to add 1 region tag.
- views/src/main/java/com/example/android/views/notifications/NotificationSnippets.java:17, tag
android_views_notifications_build_basic
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:
- Refresh this comment
@cartland
cartland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the snippet on this page: https://developer.android.com/develop/ui/views/notifications/build-notification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put these imports in the version catalog, like the other imports.
@cartland
cartland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and fixed the merge conflicts in #640. It might be easier to resolve the code there.
Uh oh!
There was an error while loading. Please reload this page.
Add a basic notification snippet and associated files to the views module.
Region-Tag: android_views_notifications_build_basic
Testing workflow for GitHub code migration.