-
Notifications
You must be signed in to change notification settings - Fork 335
Comments
Added color in colors.xml for activity embedding snippets.#535
Open
Ahmedpro25 wants to merge 1 commit intoandroid:main from
Open
Added color in colors.xml for activity embedding snippets. #535Ahmedpro25 wants to merge 1 commit intoandroid:main from
Ahmedpro25 wants to merge 1 commit intoandroid:main from
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a dedicated color resource for activity embedding snippets and annotates its purpose.
- Introduce a comment to note the new color’s usage context.
- Add
divider_colorwith semi-transparent white for snippet dividers.
Comments suppressed due to low confidence (3)
misc/src/main/res/values/colors.xml:10
- [nitpick] The comment is very brief; consider elaborating to clarify exactly where this color is applied, for example: 'Divider in activity embedding preview snippets.'
<!-- For activity embedding snippets. -->
misc/src/main/res/values/colors.xml:11
- [nitpick] Resource name
divider_coloris quite generic and may collide with other dividers; consider a more specific name likeactivity_embedding_divider_colororsnippet_divider_color.
<color name="divider_color">#AAFFFFFF</color>
misc/src/main/res/values/colors.xml:11
- Semi-transparent white (#AAFFFFFF) might not meet contrast requirements on all backgrounds; verify it satisfies accessibility contrast guidelines in its intended context.
<color name="divider_color">#AAFFFFFF</color>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.