-
Notifications
You must be signed in to change notification settings - Fork 267
version catalog added; onBackPressed() replaced.#96
Open
syslogic wants to merge 22 commits intoandroid:main from
Open
version catalog added; onBackPressed() replaced. #96syslogic wants to merge 22 commits intoandroid:main from
syslogic wants to merge 22 commits intoandroid:main from
Conversation
syslogic
syslogic
commented
Sep 6, 2024
...yVault/app/src/main/java/com/example/android/authentication/myvault/ui/GetPasskeyActivity.kt
Outdated
Show resolved
Hide resolved
Author
syslogic
commented
Sep 7, 2024
com.google.android.gms.auth.api.credentials doesn't exist in later versions anymore, that's why module SmsVerification uses:
google_play_services_auth = '20.5.0'
... is not yet in use.
@JohnZoellerG
JohnZoellerG
requested review from
cy245 and
niharika2810
as code owners
October 27, 2025 15:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I've added version catalogs and updated most of the dependencies. It was unclear where the JSON string
privilegedAllowlistcomes from (in theMyVaultapp). Meanwhile I've found methodgetGPMPrivilegedAppAllowlist()and assume it should provide the desired JSON string.There's another API change, which potentially breaks the
SmsVerificationapp: It doesn't work with the latestplay-services-authdependency at version21.2.0, that's why it's kept at version20.5.0. I've also tried to addplay-services-identity-credentials16.0.0-alpha03, but it doesn't provide the missing classes. This library might be worth a newIdentityCredentialexample app.Meanwhile method
retrieveBytes()has been deprecated inBlockstoreClientwhile theBlockstoreapp doesn't have anyfun retrieveBytes(bytesRequest: RetrieveBytesRequest)yet, which is supposed to replace it.