This repository was archived by the owner on Jul 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 476
Fix issue #2 #3
Open
AnwarShahriar
wants to merge
3
commits into
android:main
from
AnwarShahriar:profileobservalblefieldsviewmodel-state-fix
Open
Fix issue #2 #3
AnwarShahriar
wants to merge
3
commits into
android:main
from
AnwarShahriar:profileobservalblefieldsviewmodel-state-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...iewModel was set as a wrong value
googlebot
commented
Apr 10, 2018
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
Author
AnwarShahriar
commented
Apr 10, 2018
I signed it!
googlebot
commented
Apr 10, 2018
CLAs look good, thanks!
alinhayati
commented
Oct 14, 2018
Why isn't this issue merged to master then?
19diwakar
19diwakar
approved these changes
Nov 7, 2019
...profileobservalblefieldsviewmodel-state-fix � Conflicts: � BasicSample/app/src/main/java/com/example/android/databinding/basicsample/data/ProfileObservableViewModel.kt
Author
AnwarShahriar
commented
Nov 16, 2019
@diwakarsinghdiwakar this branch is updated and the conflicts are resolved. I believe this is now ready to be merged.
Author
AnwarShahriar
commented
Jul 13, 2021
@codingjeremy should we close it or there is still chances to get it merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
@JoseAlcerreca I actually don't know how to approach this, I didn't contribute before so much. This fix the problem stated at issue #2 . Let me know if further modification needed.
(削除) I think some refactoring could be done on ViewModels to move out the duplicate parts. (削除ここまで)Refactored a little bit as popularity decision logic based on like count is common on bothProfileObservableViewModelandProfileObservableFieldsViewModel.