Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

extraClassName #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aymericbouzy wants to merge 1 commit into andreypopp:master
base: master
Choose a base branch
Loading
from aymericbouzy:master
Open

Conversation

Copy link

@aymericbouzy aymericbouzy commented Mar 16, 2017
edited
Loading

Before I write tests for it, is this the way you envisioned it?

Copy link
Owner

Looks good, but the tests are failing. I think at this point we might need to migrate to Jest test runner and use its snapshot testing functionality so updating snapshots can be done automatically.

Copy link
Author

Migrating to Jest test runner is a different PR IMO. Would you like to do it now? Or I can update the tests to make them pass.

Copy link
Owner

andreypopp commented Mar 16, 2017 via email

You can just update the tests.
...
On 2017年3月16日 at 15:07 Aymeric Bouzy ***@***.***> wrote: Migrating to Jest test runner is a different PR IMO. Would you like to do it now? Or I can update the tests to make them pass. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB3glSoXrElPAxRxwlzf7KBgVn4iAnfks5rmSYZgaJpZM4MfG_x> .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /